Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for improvement #4

Open
EmilioFreire opened this issue Apr 26, 2018 · 2 comments
Open

Suggestions for improvement #4

EmilioFreire opened this issue Apr 26, 2018 · 2 comments

Comments

@EmilioFreire
Copy link

Hi Dheeraj,

Thank you again for this great package! I've been using it quite a lot recently and have a few suggestions for improvement:

  • Adding the "time in force" argument to the add_order function for limit orders (good till canceled GTC, good till time GTT, immediate or cancel IOC, and fill or kill FOK). This would helps with the flow in the buying and selling loops.
  • Adding the "funds" argument to the add_order function for market orders. This would be super helpful in order to use the full amount in the balance to buy. At the moment, "size" needs to be specified which requires a workaround in the code and leaves room for errors.

Thanks a lot!

Emilio

@RobertLangotn
Copy link

RobertLangotn commented Aug 30, 2018

Hi Dheeraj,

First and foremost I wanted to thank you for this CRAN package. I have had great success using it and have really enjoyed it overall!

I want to suggest a single improvement:

  • I often trade using limit orders to reduce the fees that I have to pay to GDAX. With this in mind it would be greatly helpful if there was the option in the add_order function to do "post only" trades (as apposed to maker or taker orders).

I'm not sure how difficult this would be to implement but like I said it would be a very nice improvement for those of us that use limit orders heavily.

Thank you for the package and your consideration!
Rob L

@bmafarj1
Copy link

bmafarj1 commented Nov 6, 2021

Hi Dheeraj,

Thank you for this package! One question I had, when I use the public_ticker or even public_candles function the current time stamp loaded in by the API call is incorrect, for instance I am living on the east coast in the US and follow EST timezone, its currently 15:40 (military time) or (3:40pm in non military time).. However when I run these functions right now the timestamp loaded in says that it is 19:40 (military time) or 7:40pm in non military time) not sure if this is an issue in the package, the API, coinbasepro? Anyone know why I might be seeing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants