Freeze when trying to get worklist data from Topcon Harmony worklist

[qarmin]

When using Topcon Harmony worklist, we have very strange freezes
Also dicom-findscu have problems and also have freeze when reading this data

dicom-findscu TOPCON@192.168.10.144:30001  -W -q PatientName=*

We are using code similar to

dicom-rs/findscu/src/main.rs

Lines 265 to 276 in 6dc8782

	let rsp_pdu = scu
	.receive()
	.whatever_context("Failed to receive response from remote node")?;
	match rsp_pdu {
	Pdu::PData { data } => {
	let data_value = &data[0];
	let cmd_obj = InMemDicomObject::read_dataset_with_ts(
	&data_value.data[..],
	&entries::IMPLICIT_VR_LITTLE_ENDIAN.erased(),
	)

When requesting for patients, worklist server returns data with size 2 instead 1

This is output of test patient from orthanC

&data.get(0) = Some(PDataValue { presentation_context_id: 1, value_type: Command, is_last: true, data: [0, 0, 0, 0, 4, 0, 0, 0, 70, 0, 0, 0, 0, 0, 2, 0, 22, 0, 0, 0, 49, 46, 50, 46, 56, 52, 48, 46, 49, 48, 48, 48, 56, 46, 53, 46, 49, 46, 52, 46, 51, 49, 0, 0, 0, 1, 2, 0, 0, 0, 32, 128, 0, 0, 32, 1, 2, 0, 0, 0, 1, 0, 0, 0, 0, 8, 2, 0, 0, 0, 1, 1, 0, 0, 0, 9, 2, 0, 0, 0, 0, 0] })
&data.get(1) = None

and this is output from test patient from Harmony

&data.get(0) = Some(PDataValue { presentation_context_id: 1, value_type: Command, is_last: true, data: [0, 0, 0, 0, 4, 0, 0, 0, 70, 0, 0, 0, 0, 0, 2, 0, 22, 0, 0, 0, 49, 46, 50, 46, 56, 52, 48, 46, 49, 48, 48, 48, 56, 46, 53, 46, 49, 46, 52, 46, 51, 49, 0, 0, 0, 1, 2, 0, 0, 0, 32, 128, 0, 0, 32, 1, 2, 0, 0, 0, 1, 0, 0, 0, 0, 8, 2, 0, 0, 0, 0, 0, 0, 0, 0, 9, 2, 0, 0, 0, 0, 255] })
&data.get(1) = Some(PDataValue { presentation_context_id: 1, value_type: Data, is_last: true, data: [8, 0, 5, 0, 67, 83, 10, 0, 73, 83, 79, 95, 73, 82, 32, 49, 57, 50, 8, 0, 130, 0, 83, 81, 0, 0, 255, 255, 255, 255, 254, 255, 0, 224, 255, 255, 255, 255, 8, 0, 0, 1, 83, 72, 16, 0, 70, 114, 101, 121, 95, 77, 101, 100, 105, 99, 97, 108, 95, 69, 88, 32, 254, 255, 13, 224, 0, 0, 0, 0, 254, 255, 221, 224, 0, 0, 0, 0, 16, 0, 16, 0, 80, 78, 16, 0, 65, 97, 97, 97, 97, 97, 97, 97, 94, 66, 98, 98, 98, 98, 98, 98, 16, 0, 32, 0, 76, 79, 4, 0, 48, 54, 50, 55, 16, 0, 48, 0, 68, 65, 8, 0, 50, 48, 49, 49, 48, 54, 48, 57, 16, 0, 64, 0, 67, 83, 2, 0, 77, 32, 64, 0, 0, 1, 83, 81, 0, 0, 255, 255, 255, 255, 254, 255, 0, 224, 255, 255, 255, 255, 64, 0, 2, 0, 68, 65, 8, 0, 50, 48, 50, 52, 48, 54, 50, 55, 254, 255, 13, 224, 0, 0, 0, 0, 254, 255, 221, 224, 0, 0, 0, 0] })

decoding this values via

                if let Some(first) = data.get(0) {
                    dbg_short!(InMemDicomObject::read_dataset_with_ts(
                        first.data.as_slice(),
                        &entries::IMPLICIT_VR_LITTLE_ENDIAN.erased()
                    ));
                }
                if let Some(second) = data.get(1) {
                    dbg_short!(InMemDicomObject::read_dataset_with_ts(
                        second.data.as_slice(),
                        &entries::IMPLICIT_VR_LITTLE_ENDIAN.erased()
                    ));
                }

produce such info

InMemDicomObject::read_dataset_with_ts(first.data.as_slice(),
    &entries::IMPLICIT_VR_LITTLE_ENDIAN.erased()) = Ok(InMemDicomObject { entries: {Tag(0x0000, 0x0000): DataElement { header: DataElementHeader { tag: Tag(0x0000, 0x0000), vr: UL, len: Length(4) }, value: Primitive(U32([70])) }, Tag(0x0000, 0x0002): DataElement { header: DataElementHeader { tag: Tag(0x0000, 0x0002), vr: UI, len: Length(22) }, value: Primitive(Strs(["1.2.840.10008.5.1.4.31"])) }, Tag(0x0000, 0x0100): DataElement { header: DataElementHeader { tag: Tag(0x0000, 0x0100), vr: US, len: Length(2) }, value: Primitive(U16([32800])) }, Tag(0x0000, 0x0120): DataElement { header: DataElementHeader { tag: Tag(0x0000, 0x0120), vr: US, len: Length(2) }, value: Primitive(U16([1])) }, Tag(0x0000, 0x0800): DataElement { header: DataElementHeader { tag: Tag(0x0000, 0x0800), vr: US, len: Length(2) }, value: Primitive(U16([0])) }, Tag(0x0000, 0x0900): DataElement { header: DataElementHeader { tag: Tag(0x0000, 0x0900), vr: US, len: Length(2) }, value: Primitive(U16([65280])) }}, dict: StandardDataDictionary, len: Length(Undefined), charset_changed: false })

InMemDicomObject::read_dataset_with_ts(second.data.as_slice(),
    &entries::IMPLICIT_VR_LITTLE_ENDIAN.erased()) = Err(ReadToken { source: ReadValue { len: 676675, tag: Tag(0x0008, 0x0005), source: ReadValueData { position: 8, source: Error { kind: UnexpectedEof, message: "failed to fill whole buffer" }, backtrace: Backtrace [{ fn: "snafu::backtrace_impl::<impl snafu::GenerateImplicitData for std::backtrace::Backtrace>::generate" }, { fn: "snafu::GenerateImplicitData::generate_with_source" }, { fn: "<dicom_parser::stateful::decode::ReadValueDataSnafu<__T0> as snafu::IntoError<dicom_parser::stateful::decode::Error>>::into_error" }, { fn: "<core::result::Result<T,E> as snafu::ResultExt<T,E>>::context" }, { fn: "dicom_parser::stateful::decode::StatefulDecoder<D,S,BD,TC>::read_value_strs" }, { fn: "dicom_parser::stateful::decode::StatefulDecoder<D,S,BD>::read_value_cs" }, { fn: "<dicom_parser::stateful::decode::StatefulDecoder<D,S,BD> as dicom_parser::stateful::decode::StatefulDecode>::read_value_preserved" }, { fn: "dicom_parser::dataset::read::DataSetReader<S>::read_value" }, { fn: "<dicom_parser::dataset::read::DataSetReader<S> as core::iter::traits::iterator::Iterator>::next" }, { fn: "dicom_object::mem::InMemDicomObject<D>::build_object" }, { fn: "dicom_object::mem::InMemDicomObject<D>::read_dataset_with_dict_ts_cs" }, { fn: "dicom_object::mem::InMemDicomObject::read_dataset_with_ts" }, { fn: "dbcore::dicom::api::receive_response" }, { fn: "dbcore::dicom::api::get_worklist_patients" }, { fn: "dbcore::tasks_executor::workers::receive_worklist::worker::WorklistReceiverTask::process_worklist_receiver" }, { fn: "dbcore::tasks_executor::workers::receive_worklist::worker::WorklistReceiverTask::run_task" }, { fn: "<dbcore::tasks_executor::workers::receive_worklist::worker::WorklistReceiverTask as dbcore::common::task_executor::task::Task>::run" }, { fn: "dbcore::common::task_executor::worker::Worker::run" }, { fn: "<dbcore::tasks_executor::executor::GlobalTaskExecutor as dbcore::common::task_executor::executor::TasksExecutor<dbcore::tasks_executor::model::TaskRequest,dbcore::tasks_executor::model::TaskStateNotification>>::create_task::{{closure}}::{{closure}}" }, { fn: "std::sys_common::backtrace::__rust_begin_short_backtrace" }, { fn: "std::thread::Builder::spawn_unchecked_::{{closure}}::{{closure}}" }, { fn: "<core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once" }, { fn: "std::panicking::try::do_call" }, { fn: "__rust_try" }, { fn: "std::panicking::try" }, { fn: "std::thread::Builder::spawn_unchecked_::{{closure}}" }, { fn: "core::ops::function::FnOnce::call_once{{vtable.shim}}" }, { fn: "std::sys::unix::thread::Thread::new::thread_start" }, { fn: "start_thread", file: "./nptl/pthread_create.c", line: 442 }, { fn: "__GI___clone3", file: "./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S", line: 81 }] } } })

How can I fix this?
Sadly I cannot provide access to this server, but I can test whatever is needed to fix problem

[Enet4]

Thank you for the details. This looks heavily related with another recently reported bug: #522 A viable workaround was suggested there, maybe you can try it here as well.