From 418efece692278c36c9c8901513d92cf6ae05dc8 Mon Sep 17 00:00:00 2001 From: Sneh Koul <35871990+Sneh1999@users.noreply.github.com> Date: Fri, 6 Dec 2024 16:39:12 -0500 Subject: [PATCH] Add names to the deprecated functions to not break abi (#34) * Add names to the deprecated functions to not break abi * remove unwanted changes --- src/bridge/SequencerInbox.sol | 13 ++++++++----- src/rollup/BridgeCreator.sol | 8 ++++---- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/src/bridge/SequencerInbox.sol b/src/bridge/SequencerInbox.sol index ae755bf4..da945b18 100644 --- a/src/bridge/SequencerInbox.sol +++ b/src/bridge/SequencerInbox.sol @@ -185,7 +185,10 @@ contract SequencerInbox is DelegateCallAware, GasRefundEnabled, ISequencerInbox Deprecated because we created another `initialize` function that accepts the `EspressoTEEVerifier` contract address as a parameter which is used by the `SequencerInbox` contract to verify the TEE attestation quote. */ - function initialize(IBridge, ISequencerInbox.MaxTimeVariation calldata) external onlyDelegated { + function initialize( + IBridge bridge_, + ISequencerInbox.MaxTimeVariation calldata maxTimeVariation_ + ) external onlyDelegated { revert Deprecated(); } @@ -341,10 +344,10 @@ contract SequencerInbox is DelegateCallAware, GasRefundEnabled, ISequencerInbox /// @dev Deprecated, kept for abi generation and will be removed in the future function addSequencerL2BatchFromOrigin( - uint256, - bytes calldata, - uint256, - IGasRefunder + uint256 sequencerNumber, + bytes calldata data, + uint256 afterDelayedMessagesRead, + IGasRefunder gasRefunder ) external pure { revert Deprecated(); } diff --git a/src/rollup/BridgeCreator.sol b/src/rollup/BridgeCreator.sol index 3228f199..19fcac2f 100644 --- a/src/rollup/BridgeCreator.sol +++ b/src/rollup/BridgeCreator.sol @@ -86,10 +86,10 @@ contract BridgeCreator is Ownable { * been posted by a batch poster running in the TEE. */ function createBridge( - address, - address, - address, - ISequencerInbox.MaxTimeVariation calldata + address adminProxy, + address rollup, + address nativeToken, + ISequencerInbox.MaxTimeVariation calldata maxTimeVariation ) external returns (BridgeContracts memory) { revert Deprecated(); }