Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Flow.Launcher.ChangeQuery with requery: true expected to change query while keeping flow launcher visible #2346

Closed
2 tasks done
bluckholl opened this issue Sep 16, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@bluckholl
Copy link

Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

Problem Description

Flow.Launcher.ChangeQuery with requery: true expected to

  1. Change query while keeping flow launcher visible
  2. plugin callback def query(self, query) with the new query

Actual:
Flow launcher is hidden after action pressed (enter / click),
Only when I trigger flow launcher again ( via flow launcher hoteky) the new query shows and callback is called

To Reproduce

Add callback with python:

"Title": "test1 Hello World, this is where title goes. {}".format(('Your query is: ' + query , query)[query == '']),
"SubTitle": "This is where your subtitle goes, press enter to open Flow's url",
"IcoPath": "Images/app.png",
"JsonRPCAction":{"method":"Flow.Launcher.ChangeQuery", "parameters":[f"testing",True] }

Screenshots

Code_xrpgjECad6

Flow Launcher Version

1.16.1

Windows Build Number

10.0.19044.3086]

Error Log

Replace this line with the important log contents.
@bluckholl bluckholl added the bug Something isn't working label Sep 16, 2023
@bluckholl
Copy link
Author

bluckholl commented Sep 16, 2023

I saw in one plugin there is another parameter dontHideAfterAction that is working for this purpose,
the below is working - it change flow launcher query immediately while keeping flow launcher visible:

"Title": "test1 Hello World, this is where title goes. {}".format(('Your query is: ' + query , query)[query == '']),
"SubTitle": "This is where your subtitle goes, press enter to open Flow's url",
"IcoPath": "Images/app.png",
"JsonRPCAction":{"method":"Flow.Launcher.ChangeQuery", "parameters":[f"testing",True], "dontHideAfterAction": True }

bug can be close (not reproduce / as design)

@taooceros
Copy link
Member

This is kindly the limitation of JsonRPC v1 as we always need an execution to trigger a flow api (which will hide according to dontHideAfterAction). V2 will make the behavior more consistent #1353 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants