Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom rubocop rules #3

Open
Fryguy opened this issue May 26, 2020 · 2 comments
Open

Custom rubocop rules #3

Fryguy opened this issue May 26, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Fryguy
Copy link
Member

Fryguy commented May 26, 2020

@bdunne Can we add some custom rubocop rules here? I got to thinking about ManageIQ/manageiq#20208 and realized that a custom rule would allow us to warn people about using one method over another. We probably could also move things like our string-based diff checker that looks for instances of puts and byebug into real rules that look at the Ruby AST instead.
@Fryguy Fryguy added the question Further information is requested label May 26, 2020
@Fryguy
Copy link
Member Author

Fryguy commented May 26, 2020

cc @jrafanie

@bdunne
Copy link
Member

bdunne commented May 26, 2020

Yeah, That sounds like a good idea.

@Fryguy Fryguy added enhancement New feature or request help wanted Extra attention is needed and removed question Further information is requested labels May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fryguy @bdunne