Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of deprecated androidx.fragment:fragment:1.0.0 #54

Open
b3nk4n opened this issue Jan 31, 2024 · 2 comments
Open

Use of deprecated androidx.fragment:fragment:1.0.0 #54

b3nk4n opened this issue Jan 31, 2024 · 2 comments

Comments

@b3nk4n
Copy link

b3nk4n commented Jan 31, 2024

The following might be related to #45.

When publishing an Android app that uses your (great! ❤️ ) library for using GPGS, it shows the following waring:

Your latest production release [...] contains SDK issues

  • androidx.fragment:fragment:1.0.0
  • This SDK version has been reported as outdated. Consider upgrading to a newer version (1.1.0+).

Learn more

And after brief investigation of my projects dependencies (e.g. via ./gradlew :android:dependencies), it looks like the use of androidx.fragment:fragment:1.0.0 is coming indirectly from this library:

...
+--- de.golfgl.gdxgamesvcs:gdx-gamesvcs-android-gpgs:1.1.0
|    +--- com.google.android.gms:play-services-games:16.0.0
|    |    +--- com.google.android.gms:play-services-base:16.0.1 -> 18.0.0
|    |    |    +--- androidx.collection:collection:1.0.0
|    |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.6.0
|    |    |    |         \--- androidx.annotation:annotation-jvm:1.6.0
|    |    |    |              \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.0 -> 1.8.21
|    |    |    |                   +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.21
|    |    |    |                   \--- org.jetbrains:annotations:13.0 -> 23.0.0
|    |    |    +--- androidx.core:core:1.2.0
|    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
|    |    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0
|    |    |    |    |    +--- androidx.lifecycle:lifecycle-common:2.0.0 -> 2.1.0
|    |    |    |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
|    |    |    |    |    +--- androidx.arch.core:core-common:2.0.0 -> 2.1.0
|    |    |    |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
|    |    |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
|    |    |    |    \--- androidx.versionedparcelable:versionedparcelable:1.1.0
|    |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
|    |    |    |         \--- androidx.collection:collection:1.0.0 (*)
|    |    |    +--- androidx.fragment:fragment:1.0.0
...

Not sure how critical this is. And whether Google Play Store will at some point start rejecting apps that uses deprecated/obsolete/outdated libraries.

But maybe 🤞 this is just about bumping the com.google.android.gms:play-services-games a little?

@b3nk4n
Copy link
Author

b3nk4n commented Jan 31, 2024

Hmm, one thing is confusing me though:
The version defined here seem to be 21.0.0:

implementation 'com.google.android.gms:play-services-games:21.0.0'

But what I find in my game's dependencies in the end is a much older version 16.0.0 🤔 . And I'm using the latest version 1.1.0 of your library already.

image

@MrStahlfelge
Copy link
Owner

The code you've investigated is the latest snapshot version, so if you switch to the snapshot you are switching to 21.0.0 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants