Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data visualizations continually make server requests #33

Open
eliwinkelman opened this issue Aug 19, 2020 · 0 comments
Open

Data visualizations continually make server requests #33

eliwinkelman opened this issue Aug 19, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@eliwinkelman
Copy link
Contributor

Describe the bug
When viewing a device, the visualization component makes continual requests to the server for redundant information. This is not noticeable for the user, but it could lead to completely unnecessary server strain.

Expected behavior
The component only request the data once, or the data state is pulled up to the parent component.

To Reproduce
Steps to reproduce the behavior:

  1. Running Spool locally
  2. Create a network
  3. View your new network
  4. View the coordinator device
  5. Check the output logs from the server, they should be getting frequently repeated requests for the same information.

Additional context
This is probably a side effect of repeatedly force reloading the react components with the plotly plots to account for changes in window size. If this is the issue it can probably be fixed by pulling any server request in onEffect up to the parent component (i.e. one that isn't being force reloaded).

@eliwinkelman eliwinkelman added the bug Something isn't working label Aug 19, 2020
@eliwinkelman eliwinkelman self-assigned this Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant