Manual OpenBAS install method as described in docs.openbas.io create a partially broken installation

[antoinemzs]

Description

When manually deploying OpenBAS as per instructions found in https://docs.openbas.io/latest/deployment/installation/#manual-installation, the resulting installation will not be able to locate agent binaries.

Environment

Latest OpenBAS as of writing: 1.10.1

Reproducible Steps

Follow steps here: When manually deploying OpenBAS as per instructions found in https://docs.openbas.io/latest/deployment/installation/#manual-installation, the resulting installation will run with unexpanded Maven @..@ placeholder values treated as literals.

Expected Output

All variables should be expanded.

Actual Output

When manually deploying OpenBAS as per instructions found in https://docs.openbas.io/latest/deployment/installation/#manual-installation, the resulting installation will run with unexpanded Maven @..@ placeholder values treated as literals. This will for example lead OpenBAS to think it is running version literal @project.version@.

Additional information

Current workaround

Deleting variables from the application.properties file provided as a release artifact (e.g. in the archive in the github release) will force Spring to load values for the redacted variables that were expanded at build time.
Example:

# Global configuration
# suppress inspection "SpringBootApplicationProperties"
info.app.name=@project.description@
- # suppress inspection "SpringBootApplicationProperties"
- info.app.version=@project.version@

# OpenBAS configuration
openbas.name=@project.name@
openbas.version=@project.version@

will cause Spring to load the build-time value, for example 1.10.1 .

Suggested path to resolution

Remove @..@ placeholders from application.properties, or alternatively expand them in the file itself if the intention is to keep providing this file as part of the release artifacts. It is useful to have this file provided as it helps a user discover configuration keys, so we need to be wary that it works out of the box.

Screenshots (optional)

$ java -jar openbas-api.jar 
Standard Commons Logging discovery in action with spring-jcl: please remove commons-logging.jar from classpath in order to avoid potential conflicts
 #######  ########  ######## ##    ## ########     ###     ######
##     ## ##     ## ##       ###   ## ##     ##   ## ##   ##    ##
##     ## ##     ## ##       ####  ## ##     ##  ##   ##  ##
##     ## ########  ######   ## ## ## ########  ##     ##  ######
##     ## ##        ##       ##  #### ##     ## #########       ##
##     ## ##        ##       ##   ### ##     ## ##     ## ##    ##
 #######  ##        ######## ##    ## ########  ##     ##  ######
@project.version@