SortBy-Hot doesn't work

[waitgain]

Semper's Harbor Freight post had -2 and I posted a new deal, yet his was still placed above mine.

[waitgain]

Note the time stamps.

[psineur]

We need to test "Hot" sort better - if it doesn't work at all - something should be done.
Minimal: it should be removed from the front-end
Ideally: it should be fixed - YC or reddit algo can be used if full-implementation is needed

[danielgsims]

Here's where the ranking is set: https://github.com/TheRealGD/therealgd/blob/develop/src/Entity/Submission.php#L327-L340

Almost any time the submission is updated, they had the entity recalculate it's ranking score so that the submissions can be indexed by rankings. Unfortunately, it means migrating every submission when tweaking the ranking algorithm.

Also, here's where the sorting actually happens in the SubmissionRepository: https://github.com/TheRealGD/therealgd/blob/develop/src/Repository/SubmissionRepository.php#L180-L183

[nautbot]

Please see issue #148 I created earlier today regarding ranking algorithms. @DEVxALMIGHTY and I can probably help with this, should we need to make it a v1 priority.

[psineur]

I prefer New, but I'm pretty sure Hot is critical.
Assigned to naut and DEVX

[psineur]

This is in progress now on triage board

[nautbot]

For the time being, let's replace the existing "hot" formula with the xkcd formula:

from datetime import datetime, timedelta
from math import log

epoch = datetime(1970, 1, 1)

def epoch_seconds(date):
    td = date - epoch
    return td.days * 86400 + td.seconds + (float(td.microseconds) / 1000000)

def hot(ups, downs, date):
    s = ups - downs
    order = log(max(abs(s), 1), 10)
    sign = 1 if s > 0 else -1 if s < 0 else 0
    seconds = epoch_seconds(date) - 1134028003
    return round(sign * order + (seconds / 45000), 7)

I don't know how to PHP, so whoever can implement ¯\_(ツ)_/¯

[psineur]

There's also something done in #200 IIRC on this. Should look at both before implementing