Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

want smartlogin to support administrator role #3

Open
arekinath opened this issue Oct 1, 2019 · 5 comments
Open

want smartlogin to support administrator role #3

arekinath opened this issue Oct 1, 2019 · 5 comments

Comments

@arekinath
Copy link
Contributor

It'd be great to have full RBAC support in smartlogin, but in the interim, just having support for the "administrator" role to grant smartlogin access would be great.

@arekinath
Copy link
Contributor Author

The loadKeys() function in the CAPI shim of UFDS is what smartlogin eventually calls. It also backs the /customer/:uuid/keys endpoint on the shim, but that shound't be used by anything else today anyway.

@arekinath
Copy link
Contributor Author

arekinath commented Oct 1, 2019

Testing done so far (sdc-ufds):

  • Hot-patched into ufds zone
  • Verified that both sub-users in the administrator role and other accounts in it have their keys added to the /customers/:uuid/keys endpoint using curl
  • Tested smartlogin by SSH'ing to a base64 zone

For the cloudapi CR

  • Hot-patched into a cloudapi zone
  • Verified that now a group account with no keys of its own (but other accounts in the administrator role) can now provision
  • Verified that a newly provisioned zone in the group account now gets the keys in root_authorized_keys from all the administrators of the group

arekinath added a commit to arekinath/sdc-cloudapi that referenced this issue Oct 1, 2019
@arekinath
Copy link
Contributor Author

Issue in ps#2 on both:

  • Using 'sub' as the search scope for keys will include keys on sub-users for account members of the role (which we don't want)

Testing done on ps#3:

  • Re-did testing from earlier
  • Also tested with an account member which has a sub-user, verified that its keys now don't make it into the list and aren't accepted by smartlogin

@bahamat
Copy link
Member

bahamat commented Oct 3, 2019

@arekinath
Copy link
Contributor Author

trentm pushed a commit to TritonDataCenter/sdc-cloudapi that referenced this issue Oct 18, 2019
arekinath added a commit to arekinath/sdc-cloudapi that referenced this issue Jan 20, 2020
arekinath added a commit to arekinath/sdc-cloudapi that referenced this issue Jan 20, 2020
arekinath added a commit to arekinath/sdc-cloudapi that referenced this issue Jan 21, 2020
kusor pushed a commit that referenced this issue Apr 7, 2020
Co-authored-by: Alex Wilson <alex@uq.edu.au>
kusor pushed a commit to TritonDataCenter/sdc-cloudapi that referenced this issue Apr 7, 2020
…role (#40)

Co-authored-by: Alex Wilson <alex@uq.edu.au>
arekinath added a commit to arekinath/sdc-cloudapi that referenced this issue May 27, 2020
arekinath added a commit to arekinath/sdc-cloudapi that referenced this issue Jul 20, 2020
arekinath added a commit to eait-itig/sdc-cloudapi that referenced this issue Apr 5, 2021
arekinath added a commit to eait-itig/sdc-cloudapi that referenced this issue Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants