Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancellation support when listing directory entries... #70

Open
sean- opened this issue Dec 11, 2017 · 0 comments
Open

Add cancellation support when listing directory entries... #70

sean- opened this issue Dec 11, 2017 · 0 comments

Comments

@sean-
Copy link
Contributor

sean- commented Dec 11, 2017

See #69 (comment) for details. Without cancellation, it's possible for the scanner.Scan() to block indefinitely attempting to wait for more data. The loop will end when the TCP connection is closed, but this should obey normal timeout/deadline semantics.

https://github.com/joyent/triton-go/blob/master/storage/directory.go#L65-L74

@jwreagor jwreagor added this to the 1.x milestone Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants