Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script issue-ecr.sh incompatible with recent versions of keripy #92

Closed
lenkan opened this issue Nov 2, 2023 · 2 comments
Closed

Script issue-ecr.sh incompatible with recent versions of keripy #92

lenkan opened this issue Nov 2, 2023 · 2 comments
Assignees

Comments

@lenkan
Copy link
Contributor

lenkan commented Nov 2, 2023

Description

I tried to run the issue-ecr.sh script on the development branch. Currently, it uses kli vc issue and kli vc accept, but these commands has been removed from the KLI, see WebOfTrust/keripy@c390d90.

See references the commands here

kli vc issue --name qvi --alias qvi --registry-name vLEI-qvi --schema ENPXp1vQzRF6JwIuS-mp2U8Uf1MoADoP_GqQ62VsDZWY --recipient EIitNxxiNFXC1HDcPygyfyv3KUlBfS_Zf-ZYOvwjpTuz --data @"${KERI_DEMO_SCRIPT_DIR}"/data/legal-entity-data.json --edges @/tmp/legal-entity-edges.json --rules @"${KERI_DEMO_SCRIPT_DIR}"/data/rules.json

Currently, signifypy does not pin a version or commit of keripy in its dependencies, see https://github.com/WebOfTrust/signifypy/blob/development/setup.py#L68.

So when I do pip install -r requirements.txt, I get the latest version of keripy (kli) without kli vc issue and kli vc accept.

Expected result

./scripts/issue-ecr.sh works

Actual result

./scripts/issue-ecr.sh fails due to missing kli vc accept

@pfeairheller pfeairheller self-assigned this Nov 2, 2023
@pfeairheller
Copy link
Member

I have a fix for this. I'll submit a PR later today.

@lenkan
Copy link
Contributor Author

lenkan commented Nov 7, 2023

This was solved in #93

@lenkan lenkan closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants