Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files being included that are not part of the files array #3

Open
FrederickEngelhardt opened this issue Jul 22, 2020 · 0 comments
Open

Comments

@FrederickEngelhardt
Copy link

FrederickEngelhardt commented Jul 22, 2020

Looks like there is the ability to pass files directly to the roku-development config string.

So far, even when passing the files array, it still includes folders such as node_modules in the roku directory when building the app.

What roku-deploy supports is passing a files array like this:

{
  "files": [
    // default paths
    "source/**/*",
    "components/**/*",
    "images/**/*",
    "manifest",
     // custom files
    "test/*"
  ]
}

Expected this to work

  "roku-development.files": [
    "source/**/*",
    "components/**/*",
    "images/**/*",
    "manifest"
  ]

Also noting that files seems to be an undocumented setting.

Hoping we can add the following the the config so that getConfig().get('files') picks up these files and passes them to roku-deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant