-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Magazine Article layout #71
Comments
Removed from sprint since this item must be completed after template is created. Once the template is working, the text content should get the styling. @mollyaljenkins I'm updating https://github.com/hlxsites/vg-macktrucks-com/issues/603 to reflect this dependency. |
@ZoeBeykirch When reviewing the designs, it appears that the extra left/right space is only present around the V2 Pull Quote block. Should I adjust it specifically for this block? Additionally, we should modify the block's wrapper max-width rather than the left/right padding, as no padding is set—only a max-width, and the block is horizontally centred. Based on the designs, the max-width should be 689px instead of 1040px on desktop. |
per the Figma design there should be 288 px on the left and right of the subhead, attribution, and social parts and 375 px of padding on the left and right of the article text (including pull quote). The standard 200 px padding applies to the non-article blocks (related stories, etc.) |
@ZoeBeykirch @WendyKruger I'll keep the max-width at 1040px for all blocks, except for the following:
|
@WendyKruger Hi. Alan is finalizing the styling for the Bulldog magazine article template and have a few remaining questions about the article's headline. The original AC stated that it should be an H1, but:
|
Testing completed. Everything works accordingly. |
Context/Description
As a Mack Trucks content author, I want to adjust the Magazine template spacing. Since the site is responsive it will adjust dynamically with the viewport size. In this ticket we will focus on content max-width and address vertical spacing in another ticket.
Acceptance Criteria
User AC:
Non-functional AC:
Attachment / link to Figma
Desktop: https://www.figma.com/design/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?m=dev&node-id=14119-2389
Mobile: https://www.figma.com/design/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?m=dev&node-id=2222-52896
The text was updated successfully, but these errors were encountered: