From 6a7f82fd3588df9b5cdcd24714601da78d25ad81 Mon Sep 17 00:00:00 2001 From: Philip Potter Date: Fri, 4 Oct 2019 16:39:16 +0100 Subject: [PATCH] disable system-cluster-critical on cluster-autoscaler for now You can't use `system-cluster-critical` on pods in namespaces other than `kube-system` because of the priority admission controller: https://github.com/kubernetes/kubernetes/blob/ded22e39755418ddeaafd2cac5fde8af6f4443ec/plugin/pkg/admission/priority/admission.go#L148 Disable this for now. We want to re-enable it (probably by somehow migrating the cluster autoscaler to kube-system) but for now, to get it running at all, let's just comment it out. --- charts/gsp-cluster/values.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/charts/gsp-cluster/values.yaml b/charts/gsp-cluster/values.yaml index 84e74aeaf..ecce9fef9 100644 --- a/charts/gsp-cluster/values.yaml +++ b/charts/gsp-cluster/values.yaml @@ -65,7 +65,8 @@ cluster-autoscaler: balance-similar-node-groups: true image: tag: v1.14.5 # upgrade this when upgrading kubernetes - priorityClassName: system-cluster-critical + # we can only set this if cluster-autoscaler is in the kube-system namespace D: + # priorityClassName: system-cluster-critical serviceMonitor: enabled: true namespace: gsp-system