Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Design System date format in Support app #1421

Open
5 of 7 tasks
AgaDufrat opened this issue Jul 22, 2024 · 1 comment · Fixed by #1415
Open
5 of 7 tasks

Use Design System date format in Support app #1421

AgaDufrat opened this issue Jul 22, 2024 · 1 comment · Fixed by #1415
Assignees

Comments

@AgaDufrat
Copy link
Contributor

AgaDufrat commented Jul 22, 2024

What

Replace date picker in the following forms:

in Support app to use Design System date format: https://design-system.service.gov.uk/patterns/dates/ (separate fields for day, month, year). Add relevant validations.

NB: we are not converting the forms to Design System

Why

Date picker arrows in Support app stopped working after the migration to Dart Sass. It’s caused by a known issue in the way Dart Sass handles the icon as Unicode - sass/sass#1395 we were not able to find a workaround. Date picker are not very accessible. When users are filling the dates in the form they normally know them already (and don’t need to pick it by looking at a calendar).

Users see a symbol instead of an arrow. There’s alt text (Next, Prev). It’s also possible to enter date manually.

This will allow us to drop dependency on jquery-ui-rails.

@nicholsj
Copy link
Contributor

nicholsj commented Dec 3, 2024

Reopening because we still need to remove date picker from 2 fields in Feedback Explorer: https://support.staging.publishing.service.gov.uk/anonymous_feedback/explore
before we can remove "jquery-ui-rails" dependency.

I've added that to the task list

@nicholsj nicholsj reopened this Dec 3, 2024
@PeterHattyar PeterHattyar removed their assignment Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants