Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons in web need some kind of explanation on hover or similar #7

Open
unhammer opened this issue Nov 10, 2021 · 8 comments
Open
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@unhammer
Copy link
Member

unhammer commented Nov 10, 2021

bilde
Nothing happens when I click Diff/Inserted/Deleted – when are they supposed to do anything? There is a diff between output and gold.

Also, especially when looking at Generator output, it's a bit confusing that the second line there actually is the generator output (gold and input are labelled, but it doesn't say Output before the output).

And why are there three "Replace as gold", "Add as gold" and "Add new gold" – why isn't "Replace as gold" and "Add new gold" enough? (If there isn't a gold already, perhaps s/Replace/Add.)

I can see that generator is accepted because I can't press the button, but what then does Accept result do?

Could perhaps have a little tutorial thing at the top of the screen.

@unhammer unhammer added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 10, 2021
@TinoDidriksen
Copy link
Member

TinoDidriksen commented Nov 10, 2021

Diff/Inserted/Deleted only makes sense for steps in red tabs. They should be disabled when on a blue tab.

Accept Result accepts all steps, so this button is usable on all tabs.

All 3 Gold buttons are needed, but you're right they're not all needed all the time. If there is no gold, then only Add As and Add New are needed. The Replace button only makes sense if there are golds. Add New is the manual input from 59895ef

In general, I want all buttons to be on screen, but merely greyed out. It's jarring if buttons change position depending on what's available.

"doesn't say Output before the output" was intentional because the label takes up too much space normally, but when there are golds then it makes sense to show it.

But yes, this needs more documentation.

@unhammer
Copy link
Member Author

It's jarring if buttons change position depending on what's available.

Sure, that makes it easier to quickly click things. I think the grey could be greyer though (I had to try hovering over "accept: generator" before I convinced myself it wasn't clickable).

@unhammer
Copy link
Member Author

copy-pasting irc for posterity:

Unhammer> I had no idea "Add new" was in input form. Hm, I read it as "add
this output as a new gold" [11:21]
TinoDidriksen> Could rename that "Manual Gold".
Unhammer> perhaps with a ↓ or ▼ or something to show that a popup appears

@TinoDidriksen
Copy link
Member

the grey could be greyer

Sure, can do that. In addition to marking them disabled, we can change the base color to btn-outline-secondary

@mr-martian
Copy link
Collaborator

I think I did most of the things discussed here. @unhammer did I miss anything?

@unhammer
Copy link
Member Author

Looks much better =D

I do think some help text at the top would be nice too, but I'm not sure what it should say. (Some kind of friendly intro to how to use it.)

I also just learnt what the diff/inserted/deleted buttons do. Since at most one works at a time, I think maybe they should be styled in a way that shows that (traditionally that'd be radio buttons, but maybe there's a bootstrappier way to do that IANADesigner)

@xavivars
Copy link
Member

xavivars commented Dec 10, 2021

The accept button is still confusing for me....
image

It says accept all except the entire output: why is that? what if I want all (including the entire output) to be accepted?

@TinoDidriksen
Copy link
Member

That's a typo. accept sounds like except, and it should be accept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants