-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buttons in web need some kind of explanation on hover or similar #7
Comments
Diff/Inserted/Deleted only makes sense for steps in red tabs. They should be disabled when on a blue tab.
All 3 Gold buttons are needed, but you're right they're not all needed all the time. If there is no gold, then only In general, I want all buttons to be on screen, but merely greyed out. It's jarring if buttons change position depending on what's available. "doesn't say Output before the output" was intentional because the label takes up too much space normally, but when there are golds then it makes sense to show it. But yes, this needs more documentation. |
Sure, that makes it easier to quickly click things. I think the grey could be greyer though (I had to try hovering over "accept: generator" before I convinced myself it wasn't clickable). |
copy-pasting irc for posterity:
|
Sure, can do that. In addition to marking them disabled, we can change the base color to |
I think I did most of the things discussed here. @unhammer did I miss anything? |
Looks much better =D I do think some help text at the top would be nice too, but I'm not sure what it should say. (Some kind of friendly intro to how to use it.) I also just learnt what the diff/inserted/deleted buttons do. Since at most one works at a time, I think maybe they should be styled in a way that shows that (traditionally that'd be radio buttons, but maybe there's a bootstrappier way to do that IANADesigner) |
That's a typo. |
Nothing happens when I click Diff/Inserted/Deleted – when are they supposed to do anything? There is a diff between output and gold.
Also, especially when looking at Generator output, it's a bit confusing that the second line there actually is the generator output (gold and input are labelled, but it doesn't say Output before the output).
And why are there three "Replace as gold", "Add as gold" and "Add new gold" – why isn't "Replace as gold" and "Add new gold" enough? (If there isn't a gold already, perhaps s/Replace/Add.)
I can see that generator is accepted because I can't press the button, but what then does
Accept result
do?Could perhaps have a little tutorial thing at the top of the screen.
The text was updated successfully, but these errors were encountered: