Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Support #37

Open
sk3tch opened this issue Jul 27, 2021 · 3 comments
Open

Batch Support #37

sk3tch opened this issue Jul 27, 2021 · 3 comments

Comments

@sk3tch
Copy link

sk3tch commented Jul 27, 2021

I reached out to Mike Perham about batch support in Python and he asked me to open an issue here.

@mperham
Copy link

mperham commented Jul 27, 2021

Thanks!

The Ruby gem provides the best and easiest reference for batch clients in other languages. The Faktory::Batch object represents a Batch:

https://github.com/contribsys/faktory_worker_ruby/blob/master/lib/faktory/batch.rb

and the BATCH protocol operations are implemented in Faktory::Client:

https://github.com/contribsys/faktory_worker_ruby/blob/c58f758d4c6d79bd57be71354c2a55a5149dd079/lib/faktory/client.rb#L76-L126

Finally, the batch client middleware connects each new job with its associated Batch when it is sent to Faktory:

https://github.com/contribsys/faktory_worker_ruby/blob/master/lib/faktory/middleware/batch.rb

If this is something you are interested in supporting in Python, let me know.

@ghilesmeddour
Copy link

ghilesmeddour commented Sep 11, 2021

Hi @sk3tch,

This repository doesn't seem to be maintained anymore. I've reimplemented a Faktory Python client here, I invite you to check it out. I will try to add batch support in the next days.

@cdrx
Copy link
Owner

cdrx commented Apr 30, 2022

I do maintain this repo, but don't have as much time to work on it as I would like.

I'll fix any bugs that come up (there are not many now, this project is pretty stable I think) but I won't personally implement new features.

If someone wants to build this feature and open a PR, I would gladly merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants