Modules group shape

[Rastian95]

Is there a way to check if a module is a corner and where it is connected?
It is to apply a pattern on the body like the following

[codemasher]

Hi, yes there is the QRMatrix::checkNeighbours() method:

php-qrcode/src/Data/QRMatrix.php

Lines 370 to 398 in a301af5

	/**
	* Checks the status of the neighbouring modules for the module at ($x, $y) and returns a bitmask with the results.
	*
	* The 8 flags of the bitmask represent the status of each of the neighbouring fields,
	* starting with the lowest bit for top left, going clockwise:
	*
	* 0 1 2
	* 7 # 3
	* 6 5 4
	*/
	public function checkNeighbours(int $x, int $y, int $M_TYPE = null):int{
	$bits = 0;
	foreach($this::neighbours as $bit => [$ix, $iy]){
	$ix += $x;
	$iy += $y;
	// $M_TYPE is given, skip if the field is not the same type
	if($M_TYPE !== null && !$this->checkType($ix, $iy, $M_TYPE)){
	continue;
	}
	if($this->checkType($ix, $iy, $this::IS_DARK)){
	$bits |= $bit;
	}
	}
	return $bits;
	}

Check out the "melted modules" example for how to use it:

php-qrcode/examples/svgMeltedModules.php

Lines 83 to 84 in a301af5

	$bits = $this->matrix->checkNeighbours($x, $y, null);
	$check = fn(int $all, int $any = 0):bool => ($bits & ($all | (~$any & 0xff))) === $all;

[Rastian95]

Thanks, what a great solution!!!
Another thing I am struggling with the relative svg path commands, do you recommend any tutorial or technique to create my own designs quickly?

[codemasher]

Hmm, i have most of my knowledge from the links listed here:

php-qrcode/src/Output/QRMarkupSVG.php

Lines 15 to 22 in a301af5

	/**
	* SVG output
	*
	* @see https://github.com/codemasher/php-qrcode/pull/5
	* @see https://developer.mozilla.org/en-US/docs/Web/SVG
	* @see https://www.sarasoueidan.com/demos/interactive-svg-coordinate-system/
	* @see http://apex.infogridpacific.com/SVG/svg-tutorial-contents.html
	*/

Additionally, i can offer these:
https://jakearchibald.github.io/svgomg/
https://codepen.io/leaverou/full/RmwzKv

[codemasher]

Also, there's the shapes example that i made for use with the "melted" one, which should give you an idea of the general syntax. In the "melt" example i've just replaced the coordinates with positioned variable arguments for sprintf().

[Rastian95]

I was able to achieve this result with few adjustments

In all the 2 rounded dark modules I use m0,1 h1 l-0.5,-1Z (triangle) with different orientations

Then in the 3 rounded Light modules I remove the curve removing the quadratic biezer in the respective corners

finally I removeall the 2, 1 rounded Light Modules

Thanks for all

If you want a can send you the new class, so you can tweak and do other examples

[codemasher]

Oh wow that looks amazing! Yea, sharing the code would be great!

[Rastian95]

This is the code in order to achieve the shape of the QR above

protected function darkModule(Closure $check, bool $invert):string {

        switch(true) {
            // 4 rounded
            case !$invert && $check(0b00000000, 0b01010101):
            case  $invert && $check(0b00000000, 0b00000000):
                return 'M%1$s %2$s m0.5,0 l0.5,0.5 l-0.5,0.5 l-0.5,-0.5Z';

            // 3 rounded
            case $invert && $check(0b01000000, 0b00000000):  // 135
                return 'M%1$s,%2$s m0,1 h%4$s q%3$s,0 %3$s,-%3$s v-%5$s q0,-%3$s -%3$s,-%3$s h-%5$s q-%3$s,0 -%3$s,%3$sZ';
            case $invert && $check(0b00000001, 0b00000000):  // 357
                return 'M%1$s,%2$s v%4$s q0,%3$s %3$s,%3$s h%5$s q%3$s,0 %3$s,-%3$s v-%5$s q0,-%3$s -%3$s,-%3$sZ';
            case $invert && $check(0b00000100, 0b00000000):  // 571
                return 'M%1$s,%2$s m1,0 v%4$s q0,%3$s -%3$s,%3$s h-%5$s q-%3$s,0 -%3$s,-%3$s v-%5$s q0,-%3$s %3$s,-%3$sZ';
            case $invert && $check(0b00010000, 0b00000000):  // 713
                return 'M%1$s,%2$s m1,1 h-%4$s q-%3$s,0 -%3$s,-%3$s v-%5$s q0,-%3$s %3$s,-%3$s h%5$s q%3$s,0 %3$s,%3$sZ';

            // 2 rounded
            case !$invert && $check(0b00100000, 0b01010101): // 13
            case  $invert && $check(0b00000000, 0b01110000):
                return 'M%1$s,%2$s m0,1 h1 l-0.5,-1Z';
            case !$invert && $check(0b10000000, 0b01010101): // 35
            case  $invert && $check(0b00000000, 0b11000001):
                return 'M%1$s,%2$s v1 l1,-0.5Z';
            case !$invert && $check(0b00000010, 0b01010101): // 57
            case  $invert && $check(0b00000000, 0b00000111):
                return 'M%1$s,%2$s h1 l-0.5,1Z';
            case !$invert && $check(0b00001000, 0b01010101): // 71
            case  $invert && $check(0b00000000, 0b00011100):
                return 'M%1$s,%2$s m1,1 v-1 l-1,0.5Z';
            // diagonal
            case  $invert && $check(0b01000100, 0b00000000):  // 15
                return 'M%1$s,%2$s m0,1 h%4$s q%3$s,0 %3$s,-%3$s v-%4$s h-%4$s q-%3$s,0 -%3$s,%3$sZ';
            case  $invert && $check(0b00010001, 0b00000000):  // 37
                return 'M%1$s,%2$s h%4$s q%3$s,0 %3$s,%3$s v%4$s h-%4$s q-%3$s,0 -%3$s,-%3$sZ';

            // 1 rounded
            case !$invert && $check(0b00101000, 0b01010101): // 1
            case  $invert && $check(0b00000000, 0b01111100):
                return 'M%1$s,%2$s m0,1 h1 v-1 h-%4$s q-%3$s,0 -%3$s,%3$sZ';
            case !$invert && $check(0b10100000, 0b01010101): // 3
            case  $invert && $check(0b00000000, 0b11110001):
                return 'M%1$s,%2$s h%4$s q%3$s,0 %3$s,%3$s v%4$s h-1Z';
            case !$invert && $check(0b10000010, 0b01010101): // 5
            case  $invert && $check(0b00000000, 0b11000111):
                return 'M%1$s,%2$s h1 v%4$s q0,%3$s -%3$s,%3$s h-%4$sZ';
            case !$invert && $check(0b00001010, 0b01010101): // 7
            case  $invert && $check(0b00000000, 0b00011111):
                return 'M%1$s,%2$s v%4$s q0,%3$s %3$s,%3$s h%4$s v-1Z';
            default:
                // full square
                return 'M%1$s,%2$s h1 v1 h-1Z';
        }

    }

    /**
     * returns a light module for the given values
     */
    protected function lightModule(Closure $check, bool $invert):string {

        switch(true) {
            // 4 rounded
            case !$invert && $check(0b11111111, 0b01010101):
            case  $invert && $check(0b10101010, 0b01010101):
                return 'M%1$s,%2$s h%3$s q-%3$s,0 -%3$s,%3$sz m1,0 v%3$s q0,-%3$s -%3$s,-%3$sz m0,1 h-%3$s q%3$s,0 %3$s,-%3$sz m-1,0 v-%3$s q0,%3$s %3$s,%3$sZ';

            // 3 rounded
            case !$invert && $check(0b10111111, 0b00000000):  // 135
                return 'M%1$s,%2$s h%3$sz m1,0 v%3$s q0,-%3$s -%3$s,-%3$sz m0,1 h-%3$s Z';
            case !$invert && $check(0b11111110, 0b00000000):  // 357
                return 'M%1$s,%2$s m1,0 v%3$s z m0,1 h-%3$s q%3$s,0 %3$s,-%3$sz m-1,0 v-%3$s Z';
            case !$invert && $check(0b11111011, 0b00000000):  // 571
                return 'M%1$s,%2$s h%3$s z m0,1 v-%3$s q0,%3$s %3$s,%3$sz m1,0 h-%3$s Z';
            case !$invert && $check(0b11101111, 0b00000000):  // 713
                return 'M%1$s,%2$s h%3$s q-%3$s,0 -%3$s,%3$sz m0,1 v-%3$s z m1,-1 v%3$s Z';

            // 2 rounded
            case !$invert && $check(0b10001111, 0b01110000): // 13
            case  $invert && $check(0b10001010, 0b01010101):
                //I want a little curve that connects the square to the triangle
                return 'M%1$s,%2$s ';
            case !$invert && $check(0b00111110, 0b11000001): // 35
            case  $invert && $check(0b00101010, 0b01010101):
                return 'M%1$s,%2$s ';
            case !$invert && $check(0b11111000, 0b00000111): // 57
            case  $invert && $check(0b10101000, 0b01010101):
                return 'M%1$s,%2$s ';
            case !$invert && $check(0b11100011, 0b00011100): // 71
            case  $invert && $check(0b10100010, 0b01010101):
                return 'M%1$s,%2$s';
            // diagonal
            case !$invert && $check(0b10111011, 0b00000000): // 15
                return 'M%1$s,%2$s ';
            case !$invert && $check(0b11101110, 0b00000000): // 37
                return 'M%1$s,%2$s ';

            // 1 rounded
            case !$invert && $check(0b10000011, 0b01111100): // 1
            case  $invert && $check(0b10000010, 0b01010101):
                return 'M%1$s,%2$s ';
            case !$invert && $check(0b00001110, 0b11110001): // 3
            case  $invert && $check(0b00001010, 0b01010101):
                return 'M%1$s,%2$s ';
            case !$invert && $check(0b00111000, 0b11000111): // 5
            case  $invert && $check(0b00101000, 0b01010101):
                return 'M%1$s,%2$s';
            case !$invert && $check(0b11100000, 0b00011111): // 7
            case  $invert && $check(0b10100000, 0b01010101):
                return 'M%1$s,%2$s ';
            default:
                // empty block
                return '';
        }

    }

[codemasher]

Whoa thank you! Would you mind submitting this as a PR or may I have your permission to use this code for an example?

[Rastian95]

Go ahead, use the code as an example!

[codemasher]

Thank you! ✨