Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❗ Improve testing #6

Open
demberto opened this issue May 29, 2022 · 3 comments
Open

❗ Improve testing #6

demberto opened this issue May 29, 2022 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed testing Unit tests and pytest configuration

Comments

@demberto
Copy link
Owner

demberto commented May 29, 2022 •
edited
Loading

Currently, all testing is limited to just the property getters and a few validated property setters. A fair amount of code is untested - ignore coverage scores it gets confused by descriptors
@demberto demberto added enhancement New feature or request help wanted Extra attention is needed labels May 29, 2022
@demberto demberto added this to the PyFLP 2.0.0 milestone Sep 13, 2022
demberto pushed a commit that referenced this issue Sep 17, 2022
@anandsshah
tests: separate by module, add new via #6
0ddd27c
demberto pushed a commit that referenced this issue Sep 17, 2022
@anandsshah
tests: separate by module, add new via #6
7712880
@demberto demberto pinned this issue Sep 17, 2022
@demberto demberto changed the title Improve testing ❗ Improve testing Sep 17, 2022
@demberto demberto mentioned this issue Sep 20, 2022
Closed
@demberto
Copy link
Owner Author

demberto commented Sep 27, 2022 •
edited
Loading

These FST files can be used for testing plugin parsers
image

FL Studio already has pre-made test FLPs used for diagnostics
image

@demberto demberto mentioned this issue Sep 28, 2022
Closed
demberto added a commit that referenced this issue Sep 29, 2022
@demberto
improve: test asset isolation via #6
1ab10c3
demberto added a commit that referenced this issue Sep 30, 2022
@demberto
tests: events via #6
d4d4582
demberto added a commit that referenced this issue Sep 30, 2022
@demberto
tests: improve coverage via #6
ceed78b
@demberto
Copy link
Owner Author

demberto commented Oct 6, 2022

A null test is added to make sure no changes break the serialiser

@demberto demberto added the testing Unit tests and pytest configuration label Oct 8, 2022
@demberto
Copy link
Owner Author

Setters are problematic and hard to test without reserialisation. I really could use some help.

@demberto demberto modified the milestones: PyFLP 2.0.0, 2.1.0 Mar 18, 2023
@demberto demberto removed this from the 2.1.1 milestone May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed testing Unit tests and pytest configuration
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

test-asset-isolation demberto/PyFLP
1 participant
@demberto