Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

.textrrc draft #4

Open
denysdovhan opened this issue Nov 16, 2015 · 5 comments
Open

.textrrc draft #4

denysdovhan opened this issue Nov 16, 2015 · 5 comments
Labels

Comments

@denysdovhan
Copy link
Owner

Personally, I think better to continue discuss about ability to load configuration for textr using .textrrc. I wanna talk about few important things:

How should we load .textrrc?

Should we load it from current dir or ~ (babel, jshint) or we should jump up to the parent dir and try to find there (eslint)?

Which the notation should we use?

I've written small example in #1. Does anyone have any question?

Where should be logic of finding .textrrc?

I think the best way it's leave it in textr-cli package and also add this feature to grunt-textr and gulp-textr plugins.


cc @iamstarkov @shuvalov-anton @andrepolischuk

@iamstarkov
Copy link
Collaborator

Should we load it from current dir or ~ (babel, jshint) or we should jump up to the parent dir and try to find there (eslint)?

babel, eslint are doing all the same stuff, they are looing into ./, then upwards if nothing have been found there they are looing into ~/ and upwards. Try to look at find-up

Which the notation should we use?

simple valid json is enogh, i think.

Where should be logic of finding .textrrc?

sure it belongs to the cli and not to the core. It’s interesting how gulp/grunt plugins should handle it. how its done by eslint/babel gulp/grunt plugins?

@denysdovhan
Copy link
Owner Author

Try to look at find-up

Looks nice. Maybe will use this.

simple valid json is enogh

I think so.

how its done by eslint/babel gulp/grunt plugins?

I dunno.

@andrepolischuk
Copy link
Contributor

Where should be logic of finding .textrrc?

I think we can create a separate module, for example textr-config, and import it into cli and gulp/grunt plugins. It will find .textrrc, parse and export options that we'll pass to textr

@denysdovhan
Copy link
Owner Author

I have thought about this.
31 груд. 2015 10:35 "Andrey Polischuk" notifications@github.com пише:

Where should be logic of finding .textrrc?

I think we can create a separate module, for example textr-config, and
import it into cli and gulp/grunt plugins. It will find .textrrc, parse
and export options that we'll pass to textr


Reply to this email directly or view it on GitHub
#4 (comment)
.

@andrepolischuk
Copy link
Contributor

We can use rc loader for our cases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants