Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename warning validators to post_error validators #109

Open
vergeev opened this issue Apr 13, 2018 · 0 comments
Open

Rename warning validators to post_error validators #109

vergeev opened this issue Apr 13, 2018 · 0 comments

Comments

@vergeev
Copy link
Contributor

vergeev commented Apr 13, 2018

The word "warning" makes it seem like the validators are executed unconditionally, when in reality they are only executed after a failure.
The name post_error_validator_group better describes their purpose.
Ranc58 added a commit to Ranc58/fiasko_bro that referenced this issue Aug 14, 2018
@Ranc58
issue devmanorg#109 Rename warning validators to post_error validators
c30c5c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vergeev