Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MSBuild Locator's AppDomainManager #36165

Closed
sharwell opened this issue Jun 4, 2019 · 1 comment
Closed

Use MSBuild Locator's AppDomainManager #36165

sharwell opened this issue Jun 4, 2019 · 1 comment

Comments

@sharwell
Copy link
Member

sharwell commented Jun 4, 2019

Starting with #36113, AnalyzerRunner uses the AppDomainManager from SourceBrowser to work around microsoft/MSBuildLocator#16. Once MSBuild Locator ships its own copy of a custom AppDomainManager, the changes in commit fbc4b38 should be updated to use that version instead, and the references to SourceBrowser removed from dotnet/roslyn.

@CyrusNajmabadi
Copy link
Member

Closing out as speculative. If we need to do this, we should just have a milestone and do it.

@CyrusNajmabadi CyrusNajmabadi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants