-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release first version on crates.io #154
Comments
Any updates here? |
We would need at least a published |
I've asked and there are apparently no further blockers on releasing |
A possible controversial idea before release, remove the imo it's worth the extra hassle on our side if it means users can copy and paste more freely. |
I don't think that's controversial, I agree it makes things less clear than they could be. |
Another idea: have a cargo-generate template to setup things per target? Would be even much more useful I guess. But would be more complex than the basic esp-template Also would be good to have a template for embassy (doesn't really belong here but anyway) Updating like 60 files for basic changes in initialization is not super convenient |
In theory we are now ready to release 0.1.0. Would be good to get #198 in first. Regarding the examples .... maybe we can also add an example for each chip which just shows the initialization without anything else and mention it in the other examples. The init code hopefully won't change too much so it won't need too much maintenance but we keep the example-utils for the other examples? |
I think the biggest problem is that the util stuff is macros instead of normal rust code. What about converting them from macros to functions? At least then users can just copy from there, right now they would have to copy the macros in their project, or unpick the macro logic which is a pain. |
I think I failed miserably trying to use regular functions for that before coming up with these macros 🤔 |
Could it not be implemented as free functions within corresponding HALs as most of these macros are just |
Thinking about this again I wonder if changing the examples would really improve the situation for new users at all. I assume most users will start from something generated by Besides that, the user needs to create/use the right timer - that's it - the remaining code can be copied from any of the examples. The harder part is to figure out which dependencies and features are needed. Since we are using workspace dependencies and dynamically activate some features that's slightly inconvenient t.b.h. Last step the user needs to do is remembering to link With that in mind I propose this
|
A bit off-topic, but maybe we could add a chapter/example on the no_std training where we walk the user through all of this. |
I like that idea - we can link to that from the README.md, too |
I like the ideas here, but I'd like to expand on them.
|
The |
I think we're in a good spot functionality-wise, I think we just need to focus on some documentation (not a tonne, but just bit more) and we should be ready for a crates.io release! |
i'm trying to use this crate with embassy right now, and i'm stuck setting up dependencies. when cloning this project, examples work fine, but its not very clear from the examples which dependencies a user needs to specify, and which are just brought in by the workspace on accident. i think some documentation regarding a full project setup with all dependencies, without having to mentally resolve the workspace like i have to for the examples, should be one of the documentation goals before releasing. |
Imo examples are not the place to describe project setup, even in the embassy org there are bunch of examples that include deps that are not always needed. You can always just take all of the workspace deps and cut them away one-by-one, checking your project still compiles after each one. The place we need this is inside esp-template. We should add support for embassy projects, and adding esp-wifi. |
Feel free to take a look at https://esp-rs.github.io/no_std-training/03_5_http_client.html, it might help you as its a standalone example of esp-wifi. |
i agree, ideally then the readme should point to that, so that new users dont run into the same issues. |
Seems like my problems stemmed from mixing idf /std with nostd. |
It's been about 3 months since we decided that there are no blockers remaining here. Can we at least get the task list updated please so we have some idea of where we stand on this? |
After the first release we probably should maintain a CHANGELOG.md here |
Update from the
|
After merging #343 we are ready to release |
Prerequisites before release:
embassy-net
andembassy-net-driver
Optional before release
The text was updated successfully, but these errors were encountered: