Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging on plebian startup in case of a crash #97

Closed
volllly opened this issue Aug 17, 2023 · 1 comment · Fixed by #114
Closed

Improve logging on plebian startup in case of a crash #97

volllly opened this issue Aug 17, 2023 · 1 comment · Fixed by #114
Assignees
Labels
feature-request New feature or request

Comments

@volllly
Copy link
Contributor

volllly commented Aug 17, 2023

If the Plebian crashes before its able to send logs to the Monarch the logs will be lost at the moment.

We should update the Monarch to capture and print stdout and stderr of the plebian if it crashes before giving the startup signal

@volllly
Copy link
Contributor Author

volllly commented Oct 18, 2023

To reproduce you can start the launcher twice. The second instance of the launcher should experience the behavior shown in #96.

The desired behavior would be that we see logs from these plebeian instances. These logs are lost in this case because they cannot be sent to the launcher via the grpc ProcessHostService because the second launcher instance cannot start the service (because it uses the same launcher port as the first instance).
In the case that this happens we want to capture the stdout of the plebians and print that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
2 participants