-
Notifications
You must be signed in to change notification settings - Fork 2
Not sending message to IRC channel #5
Comments
@OvermindDL1 sorry for my slow response; I didn't have notifications turned on and just saw your question now. You're correct that this resource doesn't join the channel; as documented in the README it uses You should be able to test this against Does that help? |
Also see #4 which is a PR to add "join before sending" behavior. This may be what you need for your particular situation. |
Both Freenode and Esper recently have been heavily encouraged channels not to enable that option because of recent spam attacks, so #4 is what I would need on Esper. :-) This is closed but I'm not seeing #4 merged yet if that will fix it? |
Try the latest on DockerHub and let me know how it goes! Check out the README for guidance on joining the channel (which is not default behavior). |
Cool, I'll toss it into one of my notification pipelines as a test! :-) |
Still unsure how to get it working, it did complain about the password being blank (esper and other such IRC networks have no server password), I then tried logging into a server that 'does' require a password and it's user never successfully joined (yet it still prints out the resultant json like it succeeded even though no errors were printed on stdout, same as on esper, freenode, and gamesurge). Tried 4 networks so far, 1 requires a password, it's not working on any. If the user and password are to be used for nickserv/authserv/sasl then how does the irc client know which to access to give the information? How do you login to a server that requires a password to access? |
For note, it's metadata on output:
And there are no errors being displayed in the output. |
Hi, thanks for persisting. I'll reopen this ticket. Since this is working for me on freenode and I can't reproduce this issue without asking you to share credentials, I think the best next step is for me to add some debugging output to the resource so we have more information. I'll try to do that tonight. |
Ping me when ready and I'll give it a try. It definitely should error out if it's unable to send the message though, transparently failing without a successful notification means that the people viewing the pipeline would never know a failure happened, and if the pipeline author really wants to ignore the failure then Concourse has a config for that. :-) |
Perhaps a |
Yup, that sounds like a great idea and is what I'll do. |
@OvermindDL1 v1.2.0 has shipped with |
It's looking like it's not sending a message, after some checking it looks like it never even attempts to join a channel, and a channel won't accept a message from an unjoined (and sometimes even an unregistered) user. Looking into the irc library used by this repo shows that it never even attempts to join at all, so... unsure how this is supposed to work? Any help as I'm unable to find an option to change this, or even pre-existing code in the docker image to do so?
The text was updated successfully, but these errors were encountered: