You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All existing components that need placeholder and/or title (or other attributes, such as aria-attributes) for complete accessibility purposes should allow the final user of the component to pass in intl message object as placeholder/title props without wrapping each single component in this injectIntl HOC. (Lets just do it at the source).
In what context will the pattern be used?
GM-ui projects utilize react-intl to enable language locale toggling. For complete accessibility compliance I often want to pass to the placeholders and titles but I can't pass in JSX component when pure HTML is expected, hence intl lib exposes the injectIntl HOC to handle those cases.
Does this pattern have state?
No
Progressive enhancement
How does this pattern scale up?
This fix would eliminate the need to use injectIntl wrap in all child projects that use react intl prioritize accessibility completeness
How will this pattern degrade in older browsers?
All constituents of this issue should work fine in older supported browsers
Does the new component raise any accessibility concerns?
It closes accessibility gaps by extending language locale toggling capabilities over them.
One concert is that this might throw off testing in projects that currently leverage these components since you would need to use mountWithIntl instead of mount (etc.) in your testing.
The text was updated successfully, but these errors were encountered:
Components:
FieldInput
ErrorCard
Checkbox
Button
etc.
Describe the new component
In what context will the pattern be used?
Does this pattern have state?
Progressive enhancement
How does this pattern scale up?
How will this pattern degrade in older browsers?
Does the new component raise any accessibility concerns?
One concert is that this might throw off testing in projects that currently leverage these components since you would need to use mountWithIntl instead of mount (etc.) in your testing.
The text was updated successfully, but these errors were encountered: