Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use theme background color for ToggleSwitch off background #568

Open
tilleryd opened this issue Apr 9, 2020 · 0 comments
Open

Don't use theme background color for ToggleSwitch off background #568

tilleryd opened this issue Apr 9, 2020 · 0 comments

Comments

@tilleryd
Copy link
Contributor

tilleryd commented Apr 9, 2020

Component:
ToggleSwitch

Will this modification effect the existing functionality?

no

Describe your proposed change

  • The ToggleSwitch currently uses Keen's COLOR_BACKGROUND_THREE property to drive the background color of the switch when toggled "off". If that is overridden to a light color, the foreground toggle is washed out due to the light background.

I suggest this component does not determine its "off" background color by the theme. It should not change at all since the toggle is white and unthemeable.

Supporting Images, Videos, or Links

Screen Shot 2020-04-09 at 1 11 52 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant