Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier #10

Open
joshwcomeau opened this issue Sep 21, 2017 · 1 comment · May be fixed by #11
Open

Prettier #10

joshwcomeau opened this issue Sep 21, 2017 · 1 comment · May be fixed by #11
Labels
enhancement question

Comments

@joshwcomeau
Copy link
Owner

Now that we have outside contributors (thanks @morajabi!), I think it'd be good to add a code-formatting tool like Prettier. That way there's no need for style-based nits in code reviews.

I think Prettier is the clear head-of-the-pack, and it should be really easy to implement. If anyone has thoughts about alternatives, though, don't be shy!
@morajabi
Copy link
Collaborator

Yesterday, I realized we need Prettier too! It's perfect. husky+prettier+lint-staged!

@joshwcomeau joshwcomeau linked a pull request Sep 30, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Prettier, use Husky and lint-staged to auto-commit prettification joshwcomeau/new-component
2 participants
@joshwcomeau @morajabi