Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version has missing turnmarker.css #114

Open
SilentDirge opened this issue Jan 28, 2023 · 6 comments
Open

Latest version has missing turnmarker.css #114

SilentDirge opened this issue Jan 28, 2023 · 6 comments

Comments

@SilentDirge
Copy link

For Version 2.9.0, instead of a turnmarker.css there is a turnmarker.less in the css directory. This results in an error and the module not loading.

I renamed turnmarker.less to turnmarker.css and that fixed it. Everything seemed to work fine in FVTT V10 but can't confirm there are zero issues. I would create a pull request but I don't think this repo is being maintained so this is more of an FYI for anyone running into this problem.

@coffiarts
Copy link

Sounds like a nice finding... However, I ran a quick check, but it doesn't seem to work for me. Still no turn marker showing up, but tons of console errors instead.

@Cyberwel
Copy link

Cyberwel commented Feb 3, 2023

I came accross the same issuse as repoirted by @SilentDirge, I also found renaming the file to .css allowed the module to load in the world - A quick test shows its working

I should say i still get the error in the console on loading foundry
image

@jamiltron
Copy link

Probably don't want to just rename the less, you want to compile it to css. You'll need to have installed the less compiler, most likely via npm install -g less, then you'll go to the css directory and run lessc turnmarker.less turnmarker.css

@duckpuppy
Copy link

Probably don't want to just rename the less, you want to compile it to css. You'll need to have installed the less compiler, most likely via npm install -g less, then you'll go to the css directory and run lessc turnmarker.less turnmarker.css

This is true in general for less files... however, in this specific case the content of the file is exactly the same as the compiled output. It only contains a single CSS rule that requires no actual compilation.

DarkenedOrigins added a commit to DarkenedOrigins/TurnMarker-alt that referenced this issue Apr 7, 2023
this is to fix issue reported in issue kckaiwei#114
@DarkenedOrigins
Copy link

i put a pr in lets see how it goes

@illandril
Copy link
Contributor

For any late v10 upgraders who come across this issue, here are two alternative modules that provide similar functionality:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants