Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching data fails due to newly introduced LegalFormat "canlander" #4

Open
HaHeho opened this issue Jan 10, 2025 · 1 comment
Open

Comments

@HaHeho
Copy link

HaHeho commented Jan 10, 2025

This change was implemented on Archidekt very recently. Unfortunately, this makes the entire fetching of data fail, due to the unknown LegalFormat.

  1. "Canadian Highlander" should be added to LegalFormat.
  2. The data parsing procedure should be adjusted so it errors like this are less likely to occur in the future, i.e. the API should be more resilient against minor changes in the provided JSON data.

I could provide a PR in the coming days if you're open to contributions. Please provide some feedback regarding the second point if you have an opinion how this should be implemented!

@linkian209
Copy link
Owner

Hey thanks for bringing attention to this. I am always open to contributions so feel free to make a PR if you are so inclined!

Regarding your second point, this is the 3rd time something like this has happened since I created this library. So I would definitely like to take a step back and figure out how to make things more resilient. I am open to your opinions on the matter as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants