Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is this crate specified as unix only? #6

Open
ameyabhat opened this issue Feb 12, 2024 · 3 comments
Open

Why is this crate specified as unix only? #6

ameyabhat opened this issue Feb 12, 2024 · 3 comments

Comments

@ameyabhat
Copy link

Hi Marcos! Out of curiosity, why is this crate specified as Unix only? I spent some time reading through the code, and don't see anything jumping out at me that would break on Windows machine. Is there something I'm missing that's limiting it to Unix?

@marcospb19
Copy link
Owner

Hey @ameyabhat 👋.

This was marked as Unix only because I use the UNIX-specific symlink function.

Windows has two types of symlinks, and I didn't bother to understand their differences.

It's been a thing with my projects as well, sometimes I cannot reliably guarantee that stuff will work on Windows because I don't have a Windows system.

I could put the function that uses that os::symlink behind a cfg(Unix) check tho 🤔 and it should compile fine.

@ameyabhat
Copy link
Author

got it, makes sense! That would be incredibly helpful - happy to submit a PR if that's useful for you!

@marcospb19
Copy link
Owner

Yes please submit a PR if you can :)

You can remove the "Unix-only" notice and add the cfg() on that thing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants