You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the MSBuild assemblies are loaded into the default AssemblyLoadContext. However, I'm interested in being able to load it into a seprate one so I can manage its lifetime separately from the rest of the app.
There are two ways I see this can be added:
Replace the call to AssemblyLoadContext.Default to .CurrentContextualReflectionContext (which will require adding a .NET Core 3.1+ target)
Add an overload to RegisterMSBuild{xxx}(...) that takes an AssemblyLoadContext
Problems with this:
Either way, it will only allow loading it into a single AssemblyLoadContext and currently wouldn't understand an assembly load context being unloaded
Even if it were allowed in multiple assembly load contexts, .NET SDK msbuild instances register environment variables that will continue to be process wide and would therefor potentially cause conflicts if multiple msbuild instances are loaded at once
The first problem is surmountable by changing how it's tracked that MSBuild is loaded. The second issue is something I don't have an answer for.
The text was updated successfully, but these errors were encountered:
MSBuild itself has some assumptions about running in the default ALC. I don't think we had a bug for that so I filed dotnet/msbuild#6794.
Until that is fixed, I'm not sure if there's value in changing Locator's behavior, but as soon as it's possible/supported to load MSBuild in an ALC Locator should definitely support/encourage it as well.
Currently, the MSBuild assemblies are loaded into the default AssemblyLoadContext. However, I'm interested in being able to load it into a seprate one so I can manage its lifetime separately from the rest of the app.
There are two ways I see this can be added:
AssemblyLoadContext.Default
to.CurrentContextualReflectionContext
(which will require adding a .NET Core 3.1+ target)RegisterMSBuild{xxx}(...)
that takes anAssemblyLoadContext
Problems with this:
AssemblyLoadContext
and currently wouldn't understand an assembly load context being unloadedThe first problem is surmountable by changing how it's tracked that MSBuild is loaded. The second issue is something I don't have an answer for.
The text was updated successfully, but these errors were encountered: