-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a parameter to SelectColumn to keep the row selected on repeat clicks in Single mode. #3138
Comments
Or, instead of the additional parameter, add another selection mode such as SelectMode.SingleSticky if that approach is cleaner/easier. |
indeed, I prefer the |
Yes, me too! @hml-coder as you have almost all the code fot it in place already anyway, fancy doing a PR for this? |
For sure .. although it will be my first PR. I'll review it more closely in the next couple of days. |
We'll help you through it! |
Thanks. I read the contribution instructions but I think there's more to it such as creating a fork etc. Do you have step by step info? |
Yes, create a fork first and then create a branch in your fork with the changes. Once you push to your branch, you'll be asked to create a PR |
So I fork
|
That should actually be |
Thanks. That's great because I forked |
🙋 Feature Request
Please consider adding a parameter to the
SelectColumn
component to maintain the selection of a row whenSelectMode
is set toSingle
and the same row is selected repeatedly. The default value can respect the current selection behavior.😯 Current Behavior
When the the
SelectMode
isSingle
and the selected row is clicked, the row is deselected💁 Possible Solution
💻 Examples
The text was updated successfully, but these errors were encountered: