Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview options for the sharing dialogue in Talk #10689

Closed
geonom opened this issue Oct 12, 2023 · 3 comments
Closed

Add preview options for the sharing dialogue in Talk #10689

geonom opened this issue Oct 12, 2023 · 3 comments
Labels
Milestone

Comments

@geonom
Copy link

geonom commented Oct 12, 2023

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

When I want to share a file from Nextcloud in Talk, there are no previews, making sharing images very, very tedious, especially when they do not have unique helpful names (see screenshot)

Describe the solution you'd like
I would like to have either the option to show preview images or showing preview images always in the sharing dialogue.

Describe alternatives you've considered
You could make it optional. But apart from that it is difficult to enforce a clear naming convention for hundreds of users in our case.

Additional context
grafik

@nickvergessen
Copy link
Member

When I want to share a file from Nextcloud in Talk, there are no previews, making sharing images very, very tedious, especially when they do not have unique helpful names (see screenshot)

If previews are supported by the server they should show up there. Maybe the right size was not generated yet and just needs more time to be created and then delivered to your browser.

If also after a longer waiting time they do not appear, this is a bug in the upstream library. Can you report it in …


Actually it's already reported as a regression:
nextcloud-libraries/nextcloud-dialogs#1010

So we will have to wait for upstream and will then just bump the library version once it was released

@SystemKeeper
Copy link
Contributor

Works for me with 18 rc3, can you confirm @geonom ?

@Antreesy
Copy link
Contributor

Works for Talk at stable28, older versions might require to bump nextcloud/dialogs library up to 4.2.2
So considering as closed with #10821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants