From c895ac8efbab6eb9ff03319c3bce8a068e0d326d Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 18 Dec 2023 13:07:52 -0800 Subject: [PATCH] build(deps): bump xunit from 2.6.1 to 2.6.3 (#2834) * build(deps): bump xunit from 2.6.1 to 2.6.3 Bumps [xunit](https://github.com/xunit/xunit) from 2.6.1 to 2.6.3. - [Commits](https://github.com/xunit/xunit/compare/2.6.1...2.6.3) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] * Add required async/awaits * public async void --> public async Task --------- Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Keegan Campbell --- .../Octokit.Tests.Conventions.csproj | 2 +- .../Clients/ReleasesClientTests.cs | 2 +- .../Octokit.Tests.Integration.csproj | 2 +- Octokit.Tests/AsyncEnumerableExtensionTests.cs | 6 +++--- Octokit.Tests/Caching/CachingHttpClientTests.cs | 4 ++-- Octokit.Tests/Clients/LicensesClientTests.cs | 4 ++-- .../Clients/MiscellaneousClientTests.cs | 4 ++-- .../Clients/OrganizationHooksClientTest.cs | 16 ++++++++-------- Octokit.Tests/Octokit.Tests.csproj | 2 +- 9 files changed, 21 insertions(+), 21 deletions(-) diff --git a/Octokit.Tests.Conventions/Octokit.Tests.Conventions.csproj b/Octokit.Tests.Conventions/Octokit.Tests.Conventions.csproj index 51fc496f67..be7afe6880 100644 --- a/Octokit.Tests.Conventions/Octokit.Tests.Conventions.csproj +++ b/Octokit.Tests.Conventions/Octokit.Tests.Conventions.csproj @@ -34,7 +34,7 @@ - + diff --git a/Octokit.Tests.Integration/Clients/ReleasesClientTests.cs b/Octokit.Tests.Integration/Clients/ReleasesClientTests.cs index 10b6cd08d8..9e5efcf461 100644 --- a/Octokit.Tests.Integration/Clients/ReleasesClientTests.cs +++ b/Octokit.Tests.Integration/Clients/ReleasesClientTests.cs @@ -61,7 +61,7 @@ public async Task CreateReleaseAsLatest() var firstReleaseRequest = new NewRelease("0.1") { MakeLatest = MakeLatestQualifier.False }; await _releaseClient.Create(_context.Repository.Id, firstReleaseRequest); - Assert.ThrowsAsync(async () => await _releaseClient.GetLatest(_context.RepositoryOwner, _context.RepositoryName)); + await Assert.ThrowsAsync(async () => await _releaseClient.GetLatest(_context.RepositoryOwner, _context.RepositoryName)); var secondReleaseRequest = new NewRelease("0.2") { MakeLatest = MakeLatestQualifier.True }; var secondRelease = await _releaseClient.Create(_context.Repository.Id, secondReleaseRequest); diff --git a/Octokit.Tests.Integration/Octokit.Tests.Integration.csproj b/Octokit.Tests.Integration/Octokit.Tests.Integration.csproj index 07f35a4481..aecef629b1 100644 --- a/Octokit.Tests.Integration/Octokit.Tests.Integration.csproj +++ b/Octokit.Tests.Integration/Octokit.Tests.Integration.csproj @@ -36,7 +36,7 @@ - + diff --git a/Octokit.Tests/AsyncEnumerableExtensionTests.cs b/Octokit.Tests/AsyncEnumerableExtensionTests.cs index 77d5196196..4db7505200 100644 --- a/Octokit.Tests/AsyncEnumerableExtensionTests.cs +++ b/Octokit.Tests/AsyncEnumerableExtensionTests.cs @@ -13,11 +13,11 @@ public class AsyncEnumerableExtensionTests public class ThePaginatedList { [Fact] - public void RejectsInvalidValues() + public async Task RejectsInvalidValues() { var client = Substitute.For(); - Assert.ThrowsAsync(() => client.GetAllForOrgAsync("octokit")[-1]); + await Assert.ThrowsAsync(() => client.GetAllForOrgAsync("octokit")[-1]); } [Fact] @@ -72,7 +72,7 @@ public class ThePaginationOverloads public void RejectInvalidValues() { var client = Substitute.For(); - + Assert.Throws(() => client.GetAllForUserAsync("fake", -1)); Assert.Throws(() => client.GetAllForUserAsync("fake", 0)); } diff --git a/Octokit.Tests/Caching/CachingHttpClientTests.cs b/Octokit.Tests/Caching/CachingHttpClientTests.cs index b5bcb69b8d..688766e055 100644 --- a/Octokit.Tests/Caching/CachingHttpClientTests.cs +++ b/Octokit.Tests/Caching/CachingHttpClientTests.cs @@ -20,7 +20,7 @@ public class CachingHttpClientTests public class TheSendMethod { [Fact] - public void EnsuresNonNullArguments() + public async Task EnsuresNonNullArguments() { // arrange var underlyingClient = Substitute.For(); @@ -29,7 +29,7 @@ public void EnsuresNonNullArguments() var cachingHttpClient = new CachingHttpClient(underlyingClient, responseCache); // act + assert - Assert.ThrowsAsync(() => cachingHttpClient.Send(null, CancellationToken.None)); + await Assert.ThrowsAsync(() => cachingHttpClient.Send(null, CancellationToken.None)); } [Theory] diff --git a/Octokit.Tests/Clients/LicensesClientTests.cs b/Octokit.Tests/Clients/LicensesClientTests.cs index 852c50d9ec..9e05e7f31d 100644 --- a/Octokit.Tests/Clients/LicensesClientTests.cs +++ b/Octokit.Tests/Clients/LicensesClientTests.cs @@ -21,11 +21,11 @@ public void EnsuresNonNullArguments() public class TheGetAllLicensesMethod { [Fact] - public void EnsuresNonNullArguments() + public async Task EnsuresNonNullArguments() { var client = new LicensesClient(Substitute.For()); - Assert.ThrowsAsync(() => client.GetAllLicenses(null)); + await Assert.ThrowsAsync(() => client.GetAllLicenses(null)); } [Fact] diff --git a/Octokit.Tests/Clients/MiscellaneousClientTests.cs b/Octokit.Tests/Clients/MiscellaneousClientTests.cs index 4253eb8e54..2a13efdb6c 100644 --- a/Octokit.Tests/Clients/MiscellaneousClientTests.cs +++ b/Octokit.Tests/Clients/MiscellaneousClientTests.cs @@ -207,11 +207,11 @@ public void EnsuresNonNullArguments() public class TheGetAllLicensesMethod { [Fact] - public void EnsuresNonNullArguments() + public async Task EnsuresNonNullArguments() { var client = new MiscellaneousClient(Substitute.For()); - Assert.ThrowsAsync(() => client.GetAllLicenses(null)); + await Assert.ThrowsAsync(() => client.GetAllLicenses(null)); } [Fact] diff --git a/Octokit.Tests/Clients/OrganizationHooksClientTest.cs b/Octokit.Tests/Clients/OrganizationHooksClientTest.cs index 577fee7860..fa9a593c49 100644 --- a/Octokit.Tests/Clients/OrganizationHooksClientTest.cs +++ b/Octokit.Tests/Clients/OrganizationHooksClientTest.cs @@ -123,11 +123,11 @@ public async Task EnsuresNonNullArguments() } [Fact] - public void EnsuresNonEmptyArguments() + public async Task EnsuresNonEmptyArguments() { var client = new OrganizationsClient(Substitute.For()); var config = new Dictionary { { "url", "" } }; - Assert.ThrowsAsync(() => client.Hook.Create("", new NewOrganizationHook("name", config))); + await Assert.ThrowsAsync(() => client.Hook.Create("", new NewOrganizationHook("name", config))); } [Fact] @@ -167,10 +167,10 @@ public async Task EnsuresNonNullArguments() } [Fact] - public void EnsuresNonEmptyArguments() + public async Task EnsuresNonEmptyArguments() { var client = new OrganizationsClient(Substitute.For()); - Assert.ThrowsAsync(() => client.Hook.Edit("", 123, new EditOrganizationHook())); + await Assert.ThrowsAsync(() => client.Hook.Edit("", 123, new EditOrganizationHook())); } [Fact] @@ -197,10 +197,10 @@ public async Task EnsuresNonNullArguments() } [Fact] - public void EnsuresNonEmptyArguments() + public async Task EnsuresNonEmptyArguments() { var client = new OrganizationsClient(Substitute.For()); - Assert.ThrowsAsync(() => client.Hook.Ping("", 123)); + await Assert.ThrowsAsync(() => client.Hook.Ping("", 123)); } [Fact] @@ -237,10 +237,10 @@ public async Task EnsuresNonNullArguments() } [Fact] - public void EnsuresNonEmptyArguments() + public async Task EnsuresNonEmptyArguments() { var client = new OrganizationsClient(Substitute.For()); - Assert.ThrowsAsync(() => client.Hook.Delete("", 123)); + await Assert.ThrowsAsync(() => client.Hook.Delete("", 123)); } } diff --git a/Octokit.Tests/Octokit.Tests.csproj b/Octokit.Tests/Octokit.Tests.csproj index 24a43b13c4..c36069b39d 100644 --- a/Octokit.Tests/Octokit.Tests.csproj +++ b/Octokit.Tests/Octokit.Tests.csproj @@ -35,7 +35,7 @@ - +