[BUG]: NullReferenceException thrown using IConnection.GetRaw() for JSON content in Octokit 8.0.1

[martincostello]

What happened?

Calling IConnection.GetRaw() for an endpoint that responds with non-binary content (e.g. application/json) results in a NullReferenceException being thrown when updating to Octokit 8.0.1.

This appears to be due to the changes in #2782 to handle large binary responses.

In the case where the response is not a Stream but instead is just a string, response.Body as Stream returns null, and then causes an exception here:

octokit.net/Octokit/Http/Connection.cs

Line 724 in 0238092

await stream.CopyToAsync(ms);

Fix incoming shortly, but a workaround is to use IConnection.GetRawStream() and refactor calling code to deal with Stream instead of byte[].

Versions

8.0.1

Relevant log output

System.NullReferenceException: Object reference not set to an instance of an object.
    at Octokit.Connection.StreamToByteArray(Stream stream) in /_/Octokit/Http/Connection.cs:line 724
    at Octokit.Connection.GetRaw(IRequest request) in /_/Octokit/Http/Connection.cs:line 704
    at MartinCostello.Costellobot.Pages.DeliveryModel.OnGet(Int64 id) in /_/src/Costellobot/Pages/Webhooks/Delivery.cshtml.cs:line 64

Code of Conduct

• I agree to follow this project's Code of Conduct

[martincostello]

Found through failing tests in these two Dependabot updates:

• Bump Octokit from 8.0.0 to 8.0.1 martincostello/costellobot#878
• Bump Octokit from 8.0.0 to 8.0.1 martincostello/dependabot-helper#891

[martincostello]

Also affects IRepositoryContentsClient.GetRawContent(), but in that case I can't workaround it myself.

[nickfloyd]

Hey @martincostello great catch. 🤦 This one is on me, I reviewed it and let it through and completely missed the implementations that you mentioned above.

I'll have a look at IRepositoryContentsClient.GetRawContent() and see what I can come up with. As always, thank you for doing all that you do here, and apologies for the trouble.

[martincostello]

No problem! I did push up a fix in #2791 but I fat-fingered the number into the other fix for GitVersion and it got closed when you merged it 🤦🏻‍♂️