Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Add defaults and settings validation to FFmpegConfigManager #56

Open
omeryusufyagci opened this issue Oct 24, 2024 · 2 comments
Assignees
Labels
core Media processing component, the core C++ binary. improvement Improve existing functionality urgent

Comments

@omeryusufyagci
Copy link
Owner

omeryusufyagci commented Oct 24, 2024

Currently the FFmpegConfigManager provides an interface for the FFmpeg-specific configurations and user settings.
However, it should also provide a set of sensible defaults for ease of use, and it validate each set operation performed on it.
This simplifies the process for FFmpeg users by eliminating concerns about potentially inter-dependent validations of FFmpeg settings. For more context, see #51.

@omeryusufyagci omeryusufyagci added improvement Improve existing functionality urgent core Media processing component, the core C++ binary. labels Oct 24, 2024
@omeryusufyagci omeryusufyagci self-assigned this Oct 24, 2024
@omeryusufyagci omeryusufyagci changed the title Improvement: Add defaults and settings validation to FFmpegSettingsManager Improvement: Add defaults and settings validation to FFmpegConfigManager Oct 27, 2024
@andcscott
Copy link
Contributor

andcscott commented Jan 8, 2025

Hey @omeryusufyagci, wanted to check if the revisions for #60 (commit 467fe76 on my branch) took care of this? If any refactoring is needed I'll have some time this week/next week if you'd like.

@omeryusufyagci
Copy link
Owner Author

Hey @andcscott, thanks for checking in! Yes, it has addressed it partially. Now we have defaults which is great, but I also want to ensure the config manager is entirely responsible for the validation of the fields as well. There are cases where some codecs won't work with certain other settings and of course the basic validation of each field to check if they're within bounds, and are logical to a point, etc.

If you'd like to take a pass at it, I'd gladly accept the help ! : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Media processing component, the core C++ binary. improvement Improve existing functionality urgent
Projects
None yet
Development

No branches or pull requests

2 participants