Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Playground thinks that transactions with multiple Account entitlements have multiple signers #804

Closed
joshuahannan opened this issue Sep 17, 2024 · 4 comments
Assignees
Labels
Bug Something isn't working

Comments

@joshuahannan
Copy link
Member

Describe the bug
When opening up a transaction with an account object with multiple entitlements, the playground incorrectly thinks that it requires multiple signers and won't let you submit the transaction without selecting a second signer.

To Reproduce

Expected behavior
Expected to be able to sign with a single signer

Screenshots
Screenshot 2024-09-17 at 5 02 43 PM

Desktop (please complete the following information):

  • OS: MacOSX Sonoma 14.6.1
  • Browser: Chrome
  • Version: 128.0.6613.138

Additional context
Add any other context about the problem here.

@joshuahannan joshuahannan added the Bug Something isn't working label Sep 17, 2024
@nialexsan nialexsan self-assigned this Sep 18, 2024
@nialexsan nialexsan mentioned this issue Sep 18, 2024
6 tasks
nialexsan added a commit that referenced this issue Sep 18, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in 🌊 Flow 4D Sep 18, 2024
@joshuahannan joshuahannan reopened this Sep 19, 2024
@joshuahannan
Copy link
Member Author

@nialexsan It looks like you only made the fix for transactions with 2 entitlements. If I have a transaction with 3 entitlements, it still thinks that there should be three signers when there should only be one. Can we make sure that this is true for any number of entitlements?

@nialexsan
Copy link
Contributor

@joshuahannan do you have a transaction snippet you're using?

@jribbink
Copy link
Contributor

jribbink commented Sep 19, 2024

If possible I would strongly recommend using the Cadence parser https://www.npmjs.com/package/@onflow/cadence-parser. Regex parsing transaction args is just a nightmare and we've been down this rabit hole a bunch of times in Flow JS Testing and Flow Cadut.

That being said, those repos have had their regex updated for Cadence 1.0, so you can also look here for code for parsing the args @nialexsan

@joshuahannan
Copy link
Member Author

I just forgot to do a hard refresh. My bad! I'll close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants