From bea19da9c3c7e55865cc23120d4a865095080375 Mon Sep 17 00:00:00 2001 From: Matyas Selmeci Date: Mon, 6 Nov 2023 17:34:05 -0600 Subject: [PATCH 1/3] Document advertising additional startd attributes (SOFTWARE-5324) This is one of those "if you don't know why you'd want to use it, you probably shouldn't" features but there isn't really a place for reference documentation and I don't want to have it be undocumented, so here it is. --- .../os-backfill-containers.md | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/docs/resource-sharing/os-backfill-containers.md b/docs/resource-sharing/os-backfill-containers.md index 86a979cc4..74656b913 100644 --- a/docs/resource-sharing/os-backfill-containers.md +++ b/docs/resource-sharing/os-backfill-containers.md @@ -213,6 +213,26 @@ the `--memory` argument tells Docker to kill the container if its total memory u Additionally, the processes that manage jobs also use some amount of memory. Therefore, it is important to give the container some extra room. + +### Advanced: Advertising additional pilot attributes + +You can put arbitrary additional attributes in the machine ads that you advertise to the OSPool. +These attributes will show up when you do `condor_status -l` on your machine. +This could be useful for advertising something about the way the pilot was provisioned. +To do this, volume-mount a file containing `key=value` pairs to `/etc/osg/extra-attributes.cfg`. +Keys must be valid classad attribute names and values must be valid classad expressions. +Multi-line strings are not supported. +A line starting with `#` will be treated as a comment. +For example: + +``` +# The Kubernetes namespace this pod is running under +Kubernetes_Namespace = "path-osgdev" +# The deployment for this pilot +Kubernetes_Deployment = "osgvo-docker-pilot-gpu" +``` + + Best Practices -------------- From b59de47a3cf730b552b9009cc0659ec8bc6070e6 Mon Sep 17 00:00:00 2001 From: Matyas Selmeci Date: Tue, 7 Nov 2023 11:13:31 -0600 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Brian Lin --- docs/resource-sharing/os-backfill-containers.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/resource-sharing/os-backfill-containers.md b/docs/resource-sharing/os-backfill-containers.md index 74656b913..4829ae0c0 100644 --- a/docs/resource-sharing/os-backfill-containers.md +++ b/docs/resource-sharing/os-backfill-containers.md @@ -227,9 +227,9 @@ For example: ``` # The Kubernetes namespace this pod is running under -Kubernetes_Namespace = "path-osgdev" +KUBERNETES_NAMESPACE = "path-osgdev" # The deployment for this pilot -Kubernetes_Deployment = "osgvo-docker-pilot-gpu" +KUBERNETES_DEPLOYMENT = "osgvo-docker-pilot-gpu" ``` From b3486b22ed2831c811cc7d265c6386ddef8f124a Mon Sep 17 00:00:00 2001 From: Matyas Selmeci Date: Tue, 7 Nov 2023 11:20:23 -0600 Subject: [PATCH 3/3] Apply suggestions from code review --- docs/resource-sharing/os-backfill-containers.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/resource-sharing/os-backfill-containers.md b/docs/resource-sharing/os-backfill-containers.md index 4829ae0c0..5c8286649 100644 --- a/docs/resource-sharing/os-backfill-containers.md +++ b/docs/resource-sharing/os-backfill-containers.md @@ -216,8 +216,8 @@ the `--memory` argument tells Docker to kill the container if its total memory u ### Advanced: Advertising additional pilot attributes -You can put arbitrary additional attributes in the machine ads that you advertise to the OSPool. -These attributes will show up when you do `condor_status -l` on your machine. +You can put arbitrary additional attributes in the machine ads that the pilot advertises to the OSPool. +These attributes will show up when users run `condor_status -l` against your pilot. This could be useful for advertising something about the way the pilot was provisioned. To do this, volume-mount a file containing `key=value` pairs to `/etc/osg/extra-attributes.cfg`. Keys must be valid classad attribute names and values must be valid classad expressions.