Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use state machine for file parser #14

Closed
nanxstats opened this issue Jan 15, 2025 · 0 comments · Fixed by #16
Closed

Use state machine for file parser #14

nanxstats opened this issue Jan 15, 2025 · 0 comments · Fixed by #16
Assignees
@nanxstats
Labels
enhancement New feature or request

Comments

@nanxstats
Copy link
Collaborator

Currently, parse_packed_file() in unpack.py uses a stateful approach to parse packed files, which is complex and involves too many if-elses.

We should refactor it to use state machine so that it is easy to understand and maintain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanxstats nanxstats

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite packed file parser with finite state machines pharmaverse/py-pkglite
1 participant
@nanxstats