Images in navigation portlet shown with improper URL

[zopyx]

See screenshot taken from plone-demo.info.

It shows broken images inside the navigation portlet due to the fact the the src of the images broken. It seems to contain the physical path of the object instead of the correct address related to the VHOST.

Tested with Plone 5.0.2

[thet]

Slightly related: #1322

[davilima6]

Closed in plone/plone.app.portlets#79.

[fgrcon]

rendered: https://www.plone-demo.info/**plone**/images/image-5/@@images/image/icon
should be: https://www.plone-demo.info/images/image-5/@@images/image/icon

works now since: plone/plone.app.portlets@dd25cf7#diff-9696d73de0c15089bb62b2e4bd96d4db
thanks @davilima6 , @jensens

but: now renders (without virt host) as
....192.168.1.15:8080**/Plone/**/Plone/ordner-2/140-2012-09-07_img_0454.jpg/@@images/image/icon

should?:
....192.168.1.15:8080/Plone/ordner-2/140-2012-09-07_img_0454.jpg/@@images/image/icon

(sorry was my bug, did not test with virt host)
concurrent editing :-)

[davilima6]

@fgrcon: I actually confirm the double /Plone/Plone without Vhost. I made a PR now (plone/plone.app.portlets#82) with a fix.

I didn't test with Vhost (is it possible to try it without Apache/ngnix?), but in my new commit I use getURL, which I believe should be already informed by VHM.

[fgrcon]

@davilima6 you'r right. The Monster does the translation ... . There is a new pull request plone/plone.app.portlets#83 (even simpler code) which should work in both ways.
http://jenkins.plone.org/job/pull-request-5.1/529/ let's see what jenkins thinks about it :-)

I dont know, if there is a way testing vhosts without using a Web server. I run my different plone instances on virtual machines with debian - its quite simple to configure apache or nginx ...

[davilima6]

@fgrcon: I didn't understand #83. The only diff from #82 seems to be the var name (from icon_url to thumb_url) and, more importantly, the use of node/path instead of node/getURL (which I reference as item_url). The former is how it is now in master, since imageBase is node/path, so I don't see the fix.

[fgrcon]

@davilima6 : not quite the same:
with node/getURL :
I got :
...//192.168.1.15:8080/Plone/ordner-2/140-2012-09-07_img_0454.jpg**/view**/@@images/image/icon
...//ploneori.dev/Plone/ordner-2/140-2012-09-07_img_0454.jpg/view/@@images/image/icon

But I am somewhat confused. ,Im just doing some research myself. I branched back to 3.1.3 where i did my last modifications. I still cannot reproduce the bug - it worked a as intented !!

[davilima6]

I updated plone/plone.app.portlets#82 from node/getURL to node/item/getURL because the brain doesn't include the /view/ part. I think it should be ok now :) - aka it seems we need to add some tests.

[fgrcon]

@davilima6 👍 Looks great! Now there are correct absolute paths to the thumbs (with or without vhm) which should be safe - i guess the problem was somewhere with virtual host mapping. I closed plone/plone.app.portlets#83