Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons always show in #footerportlets #69

Open
espenmn opened this issue May 3, 2016 · 1 comment
Open

Icons always show in #footerportlets #69

espenmn opened this issue May 3, 2016 · 1 comment

Comments

@espenmn
Copy link
Member

espenmn commented May 3, 2016

The icon settings in @@site control panel are not taken into account for portlets in the footer.

  1. Disable 'show icons' in @@site control panel
  2. Add news portlet to right column. The portlet is rendered without icons.
  3. Add news portlet (or review portlet) in 'footerportlets'. The portlet is rendered with icons.
@davilima6
Copy link
Member

davilima6 commented May 3, 2016

I think you meant thumbnails instead of icons, no?

Nevertheless behavior seems broken for both icons and thumbs at more than one place:

  • 1. Icons never show in news/events/review portlets. This is inconsistent with nav portlet, which acts predictably.
  • 2. When Icon visibility is off, icons aren't hidden from Toolbar's Add menu, as it happened in all previous Plone.
  • 3. Thumbs always show in news/events/review portlets when they are placed in the Footer portlet manager. It seems like by some Acquisition magic getIcon always returns True

PS: icons don't show also for navigation portlet when it's placed in footer. But that's a LESS overnesting issue, which requires that portlet to be inside of .outer-wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants