From 1a31febd7b1904b57121ffdb98215670227a456e Mon Sep 17 00:00:00 2001 From: Noah Yoshida Date: Fri, 14 Jun 2024 10:25:49 -0700 Subject: [PATCH 1/5] integration test POC --- .github/workflows/integration_tests.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/integration_tests.yaml b/.github/workflows/integration_tests.yaml index 6f109f3cb..bcc43f852 100644 --- a/.github/workflows/integration_tests.yaml +++ b/.github/workflows/integration_tests.yaml @@ -8,6 +8,11 @@ on: secrets: RUNPOD_API_KEY: required: true + workflow_dispatch: + inputs: + lorax_tag: + required: true + type: string jobs: deploy: runs-on: ubuntu-latest From be7dfaad85b6cbd47a4539951e699774fede3eb1 Mon Sep 17 00:00:00 2001 From: Noah Yoshida Date: Fri, 14 Jun 2024 10:28:12 -0700 Subject: [PATCH 2/5] test --- .github/workflows/integration_tests.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/integration_tests.yaml b/.github/workflows/integration_tests.yaml index bcc43f852..3264b90a3 100644 --- a/.github/workflows/integration_tests.yaml +++ b/.github/workflows/integration_tests.yaml @@ -1,5 +1,8 @@ name: integration-tests on: + pull_request: + branches: + - "integration-tests-v1" workflow_call: inputs: lorax_tag: From 06e7b8320ddb41394c3eddb70047fe708be2fb26 Mon Sep 17 00:00:00 2001 From: Noah Yoshida Date: Fri, 14 Jun 2024 10:33:21 -0700 Subject: [PATCH 3/5] fix --- .github/workflows/integration_tests.yaml | 3 --- tests/create-pod.sh | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/integration_tests.yaml b/.github/workflows/integration_tests.yaml index 3264b90a3..bcc43f852 100644 --- a/.github/workflows/integration_tests.yaml +++ b/.github/workflows/integration_tests.yaml @@ -1,8 +1,5 @@ name: integration-tests on: - pull_request: - branches: - - "integration-tests-v1" workflow_call: inputs: lorax_tag: diff --git a/tests/create-pod.sh b/tests/create-pod.sh index 2abc7f962..ea572a9c4 100644 --- a/tests/create-pod.sh +++ b/tests/create-pod.sh @@ -3,7 +3,7 @@ IMAGE_NAME="$1" runpodctl create pods \ --name lorax-tests-new \ --gpuType "NVIDIA A40" \ - --imageName "$IMAGE_NAME" \ + --imageName "ghcr.io/predibase/lorax:g$IMAGE_NAME" \ --containerDiskSize 100 \ --volumeSize 100 \ --ports "8080/http" \ From c57dcaa3c661589d526dc5f5a98461c9e9624e0a Mon Sep 17 00:00:00 2001 From: Noah Yoshida Date: Fri, 14 Jun 2024 10:34:47 -0700 Subject: [PATCH 4/5] fix --- tests/create-pod.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/create-pod.sh b/tests/create-pod.sh index ea572a9c4..228fb6749 100644 --- a/tests/create-pod.sh +++ b/tests/create-pod.sh @@ -1,7 +1,7 @@ IMAGE_NAME="$1" runpodctl create pods \ - --name lorax-tests-new \ + --name lorax-tests \ --gpuType "NVIDIA A40" \ --imageName "ghcr.io/predibase/lorax:g$IMAGE_NAME" \ --containerDiskSize 100 \ From f521a734c008f1183db19c8cd4f1364dee028d6b Mon Sep 17 00:00:00 2001 From: Noah Yoshida Date: Fri, 14 Jun 2024 10:39:17 -0700 Subject: [PATCH 5/5] fix --- tests/create-pod.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/create-pod.sh b/tests/create-pod.sh index 228fb6749..057b5cbd1 100644 --- a/tests/create-pod.sh +++ b/tests/create-pod.sh @@ -3,7 +3,7 @@ IMAGE_NAME="$1" runpodctl create pods \ --name lorax-tests \ --gpuType "NVIDIA A40" \ - --imageName "ghcr.io/predibase/lorax:g$IMAGE_NAME" \ + --imageName "ghcr.io/predibase/lorax:$IMAGE_NAME" \ --containerDiskSize 100 \ --volumeSize 100 \ --ports "8080/http" \