Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KNOWN BUG] Broken Support for TextOnly Models from torchtune #1430

Open
Jack-Khuu opened this issue Dec 19, 2024 · 0 comments
Open

[KNOWN BUG] Broken Support for TextOnly Models from torchtune #1430

Jack-Khuu opened this issue Dec 19, 2024 · 0 comments
Assignees
Labels
bug Something isn't working Known Gaps These are known Gaps/Issues/Bug items in torchchat torchtune Issue/PR related to torchtune components triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@Jack-Khuu
Copy link
Contributor

🐛 Describe the bug

Originally added in #1123, leveraging torchtune model definitions is something that torchchat is gradually moving towards (in contrast to locally hosting model definitions), but has been lost through pin bump/inactivity.

For example, commands like the following python3 torchchat.py generate llama3.1-tune --prompt "write me a story about a boy and his bear" shuold load the model definition using torchtune then pass back to torchchat for inference, but currently errors out on construction due to outdated function signatures.


Task: Re-enabling the ability to perform inference with: python3 torchchat.py generate llama3.1-tune --prompt "write me a story about a boy and his bear"

I imagine the process being iterative via a combination of tracing signature changes in torchchat and torchtune


A good gauge of this being fixed is that changes like: 69da96c, should be sufficient to support a new torchtune model in torchchat.

Versions

Current Main Hash: 90749d2

@Jack-Khuu Jack-Khuu added bug Something isn't working Known Gaps These are known Gaps/Issues/Bug items in torchchat triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module torchtune Issue/PR related to torchtune components labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Known Gaps These are known Gaps/Issues/Bug items in torchchat torchtune Issue/PR related to torchtune components triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

2 participants