From 496a9d427a3be63b66f2db0667fe9d3a2dceeed5 Mon Sep 17 00:00:00 2001
From: Jorge Obiols <jorge.obiols@gmail.com>
Date: Mon, 22 Jul 2024 20:32:18 -0300
Subject: [PATCH] [IMP] chequear contenido del readme

---
 .vscode/launch.json |  2 +-
 tools/gen_readme.py | 49 ++++++++++++++++++++++++++++++++++++++-------
 2 files changed, 43 insertions(+), 8 deletions(-)

diff --git a/.vscode/launch.json b/.vscode/launch.json
index 5b97c3e..0435bf3 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -7,7 +7,7 @@
         {
             "name": "Debug gen-readme proyect",
             "args": [
-                "--addons-dir=/odoo/ar/odoo-16.0e/testpy16/sources/l10n-paraguay",
+                "--addons-dir=/odoo/ar/odoo-16.0e/testpy16/sources/addons-l10n-paraguay",
                 "--org-name=tecnopro-assistance",
                 "--repo-name=l10n-paraguay",
                 "--branch=16.0",
diff --git a/tools/gen_readme.py b/tools/gen_readme.py
index 3dc14b6..22eb089 100644
--- a/tools/gen_readme.py
+++ b/tools/gen_readme.py
@@ -103,9 +103,10 @@
     # Use the short form of syntax highlighting so that the generated
     # Pygments CSS can be used to style the output.
     "syntax_highlight": "short",
+    "output_enconding": "utf-8",
+    "xml_declaration": False,
 }
 
-
 def gen_one_addon_index(readme_filename):
     """Genera el readme en html"""
     addon_dir = os.path.dirname(readme_filename)
@@ -131,11 +132,18 @@ def gen_one_addon_index(readme_filename):
     index = re.sub(
         rb"(<meta.*generator.*Docutils)\s*[\d.]+", rb"\1", index, re.MULTILINE
     )
+    # remove the http-equiv line
+    index = re.sub(
+        rb'<meta\s+http-equiv="Content-Type"\s+content="text/html;\s*charset=utf-8"\s*/?>',
+        b'',
+        index,
+        flags=re.MULTILINE | re.IGNORECASE
+    )
+
     with open(index_filename, "wb") as f:
         f.write(index)
     return index_filename
 
-
 def check_rst(readme_filename):
     with tempfile.NamedTemporaryFile() as f:
         publish_file(
@@ -145,7 +153,6 @@ def check_rst(readme_filename):
             settings_overrides=RST2HTML_SETTINGS,
         )
 
-
 def generate_fragment(org_name, repo_name, branch, addon_name, file):
     fragment_lines = file.readlines()
     if not fragment_lines:
@@ -180,6 +187,30 @@ def generate_fragment(org_name, repo_name, branch, addon_name, file):
         fragment += "\n"
     return fragment
 
+def check_readme_fragments(addon_dir):
+    """ Verifica si el contenido del readme es válido"""
+
+    files_to_check = ['CONTRIBUTORS.rst', 'DESCRIPTION.rst']
+    errors = []
+
+    for file_name in files_to_check:
+        addon_dir = os.path.join(addon_dir, file_name)
+
+        try:
+            with open(addon_dir, 'r', encoding='utf-8') as file:
+                content = file.read().strip()
+                if len(content) <= 10:
+                    errors.append(f'The section {file_name} should have more content.')
+
+        except FileNotFoundError:
+            errors.append(f'File {file_name} does not exist')
+        except Exception as e:
+            errors.append(f'Unknown exception str({e}) reading {file_name}')
+
+    for error in errors:
+        print(error)
+
+    return True if not error else False
 
 def gen_one_addon_readme(org_name, repo_name, branch, addon_name, addon_dir, manifest):
     """Genera el README.rst para el addon addon_name"""
@@ -274,6 +305,7 @@ def gen_one_addon_readme(org_name, repo_name, branch, addon_name, addon_dir, man
     help="Directory containing several addons, the README will be "
     "generated for all installable addons found there...",
 )
+
 def gen_readme(files, version, org_name, repo_name, branch, addons_dir):
     """main function"""
 
@@ -317,6 +349,9 @@ def gen_readme(files, version, org_name, repo_name, branch, addons_dir):
                 org_name, repo_name, branch, addon_name, addon_dir, manifest
             )
 
+            # Verifica que en el readme haya datos validos
+            check_readme_contents(addon_dir)
+
             # Generamos el html
             gen_one_addon_index(readme_filename)
 
@@ -330,14 +365,14 @@ def gen_readme(files, version, org_name, repo_name, branch, addons_dir):
         if not os.path.exists(os.path.join(addon_dir, FRAGMENTS_DIR)):
             os.mkdir(os.path.join(addon_dir, FRAGMENTS_DIR))
 
-        # Generar README.rst
+        # Generar fragmentos si no existen y README.rst
         readme_filename = gen_one_addon_readme(
             org_name, repo_name, branch, addon_name, addon_dir, manifest
         )
 
-        # parece que chequea que el rst sea correcto escribiendo en un temporarario
-        #        check_rst(readme_filename)
-        #        readme_filenames.append(readme_filename)
+        # Verifica que en el readme haya datos validos
+        if not check_readme_fragments(addon_dir):
+            exit(1)
 
         # if not manifest.get("preloadable", True):
         #     continue