Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Update cuSpatial to always explicitly specify RMM pool size and avoid using rmm::detail APIs #1318

Closed
Tracked by #10
harrism opened this issue Jan 11, 2024 · 0 comments · Fixed by #1319
Closed
Tracked by #10

[BUG]: Update cuSpatial to always explicitly specify RMM pool size and avoid using rmm::detail APIs #1318

harrism opened this issue Jan 11, 2024 · 0 comments · Fixed by #1319
Assignees
@harrism
Labels
improvement Improvement / enhancement to an existing function

Comments

@harrism
Copy link
Member

harrism commented Jan 11, 2024

Version

24.02

On which installation method(s) does this occur?

Docker, Conda, Source, Rapids-Compose

Describe the issue

rapidsai/rmm#1417 and followon PRs make a number of improvements and changes to help consumers of RMM avoid accessing RMM's detail namespace.

initial pool size in pool_memory_resource is required to be provided (no longer optional)
rmm::detail::available_device_memory() (moving to `rmm::available_device_memory())
Move alignment utility functions out of detail namespace.
Add utility to calculate an aligned percentage of free device memory in bytes. This way, existing instantiations of pool_memory_resource(upstream) can be replaced by pool_memory_resource(upstream, rmm::percent_of_free_device_memory(50), which matches previous behavior.

cuSpatial should be updated for these changes once rapidsai/rmm#1417 is merged. I have a PR ready to open.

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

No response
@harrism harrism added the improvement Improvement / enhancement to an existing function label Jan 11, 2024
@harrism harrism self-assigned this Jan 11, 2024
This was referenced Jan 11, 2024
Closed
Merged
rapids-bot bot pushed a commit that referenced this issue Jan 16, 2024
@harrism
Add explicit initial size to all pools and avoid RMM detail APIs (#1319)
43bb8f3 
This PR fixes up cuSpatial to avoid usage that will soon be deprecated in RMM.

Depends on rapidsai/rmm#1417

Fixes #1318

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Michael Wang (https://github.com/isVoid)

URL: #1319
@github-project-automation github-project-automation bot moved this from Todo to Done in cuSpatial Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harrism harrism

Labels
improvement Improvement / enhancement to an existing function
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add explicit initial size to all pools and avoid RMM detail APIs harrism/cuspatial
1 participant
@harrism