Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jagged strokes on Firefox #171

Closed
Luciogi opened this issue Dec 26, 2022 · 6 comments
Closed

Jagged strokes on Firefox #171

Luciogi opened this issue Dec 26, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@Luciogi
Copy link

Luciogi commented Dec 26, 2022

Describe the bug
Pen stroke is not smooth , too much edges and a bit laggy

To Reproduce
Steps to reproduce the behavior:

  1. Open firefox
  2. Goto https://saber.adil.hanney.org/#/home/whiteboard
  3. Use any pen
  4. See strokes

Expected behavior
Strokes should be smooth

Screenshots
image

Device (please complete the following information):

  • Device: Laptop
  • OS: Artix Linux
  • Version: Firefox (108.0.1 (64-bit))
@Luciogi Luciogi added the bug Something isn't working label Dec 26, 2022
@adil192 adil192 changed the title Firefox rendering issue Jagged strokes on web Dec 26, 2022
adil192 added a commit that referenced this issue Dec 27, 2022
@adil192
strokeProperties: enable smoothing on web
e485687 
#171
@Luciogi
Copy link
Author

Luciogi commented Dec 28, 2022

This only happens on firefox not on chromium based browsers

@adil192
Copy link
Member

adil192 commented Dec 28, 2022 •
edited
Loading

You're right, it seems like Firefox (including on Android) isn't updating the mouse position as often

@adil192 adil192 changed the title Jagged strokes on web Jagged strokes on Firefox Dec 28, 2022
@Luciogi
Copy link
Author

Luciogi commented Dec 28, 2022 •
edited
Loading

I have tired other app xournal++_mobile https://xournal.online/ web version it show jagged strokes also there
Edit : It also uses flutter
Edit1: When moving slowly it renders smoothly as I speed up pen movement it started to jagged

@adil192
Copy link
Member

adil192 commented Dec 29, 2022

Maybe related to steveruizok/perfect-freehand-dart#9

@Luciogi
Copy link
Author

Luciogi commented Dec 30, 2022 •
edited
Loading

@adil192 If you have Windows(OS) , test there on Firefox

@adil192
Copy link
Member

adil192 commented Feb 14, 2023

Closing as the web version has been deprecated since v0.8.1

@adil192 adil192 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adil192 @Luciogi