Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of "optimized" foundry profiles #1103

Open
andreivladbrg opened this issue Dec 2, 2024 · 1 comment
Open

Get rid of "optimized" foundry profiles #1103

andreivladbrg opened this issue Dec 2, 2024 · 1 comment
Labels
effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: build Changes that affect the build system or external dependencies. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@andreivladbrg
Copy link
Member

andreivladbrg commented Dec 2, 2024 •
edited
Loading

Foundry has released a new version which allows you to set up multiple profiles that are compiled simultaneously. Ref here.

Thus, we should remove these profiles:

also, we would be able to update the deployConditionally logic.

questions:

  1. should we updated the CI reusables to not pass the foundry profile?
  2. @PaulRBerg should we keep the smt profiles anymore? we haven’t used them at all.
@andreivladbrg andreivladbrg added type: build Changes that affect the build system or external dependencies. priority: 1 This is important. It should be dealt with shortly. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. effort: medium Default level of effort. labels Dec 2, 2024
This was referenced Dec 2, 2024
Open
Open
@andreivladbrg andreivladbrg added priority: 2 We will do our best to deal with this. and removed priority: 1 This is important. It should be dealt with shortly. labels Dec 2, 2024
@PaulRBerg
Copy link
Member

Yeah let's keep the smt profiles please.

@andreivladbrg andreivladbrg mentioned this issue Dec 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: build Changes that affect the build system or external dependencies. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaulRBerg @andreivladbrg