Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no longer needed gas gas_reports field in foundry.toml #987

Closed
andreivladbrg opened this issue Jul 25, 2024 · 0 comments · Fixed by #1005
Closed

Remove no longer needed gas gas_reports field in foundry.toml #987

andreivladbrg opened this issue Jul 25, 2024 · 0 comments · Fixed by #1005
Assignees
@andreivladbrg
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: build Changes that affect the build system or external dependencies. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@andreivladbrg
Copy link
Member

We have implemented our own methodology to benchmark the relevant functions, so can remove the gas_reports field in foundry.toml

v2-core/foundry.toml

Lines 11 to 16 in 9926384

gas_reports = [
"SablierV2LockupDynamic",
"SablierV2LockupLinear",
"SablierV2LockupTranched",
"SablierV2NFTDescriptor",
]

@andreivladbrg andreivladbrg added priority: 2 We will do our best to deal with this. effort: low Easy or tiny task that takes less than a day. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. type: chore Maintenance work. type: build Changes that affect the build system or external dependencies. and removed type: chore Maintenance work. labels Jul 25, 2024
@andreivladbrg andreivladbrg self-assigned this Jul 31, 2024
@andreivladbrg andreivladbrg mentioned this issue Jul 31, 2024
Merged
@andreivladbrg andreivladbrg linked a pull request Jul 31, 2024 that will close this issue
build: remove gas reports field in foundry.toml #1005
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreivladbrg andreivladbrg

Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: build Changes that affect the build system or external dependencies. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: remove gas reports field in foundry.toml sablier-labs/v2-core
2 participants
@smol-ninja @andreivladbrg